Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No longer deploy Solution UIs #2617

Merged
merged 4 commits into from
Aug 12, 2020
Merged

No longer deploy Solution UIs #2617

merged 4 commits into from
Aug 12, 2020

Conversation

alexandre-allard
Copy link
Contributor

Component: salt, solutions, examples

Context: See #2581

Summary:
Solution UIs are no longer deployed by the Solution framework

Acceptance criteria:
Solution tests should be green.

Closes: #2581

@alexandre-allard alexandre-allard requested a review from a team as a code owner June 11, 2020 09:38
@bert-e

This comment has been minimized.

Sign in to view
@bert-e

This comment has been minimized.

Sign in to view
@bert-e

This comment has been minimized.

Sign in to view
@alexandre-allard alexandre-allard force-pushed the improvement/2581-no-longer-deploy-solution-ui branch from af8197c to 6ed2ab8 Compare June 11, 2020 09:59
@bert-e

This comment has been minimized.

Sign in to view
@alexandre-allard
Copy link
Contributor Author

/reset

@bert-e

This comment has been minimized.

Sign in to view
@bert-e

This comment has been minimized.

Sign in to view
@bert-e

This comment has been minimized.

Sign in to view
@alexandre-allard alexandre-allard force-pushed the improvement/2581-no-longer-deploy-solution-ui branch from 6ed2ab8 to e9892aa Compare June 12, 2020 14:23
@bert-e

This comment has been minimized.

Sign in to view
@alexandre-allard alexandre-allard force-pushed the improvement/2581-no-longer-deploy-solution-ui branch from e9892aa to e31bebf Compare June 15, 2020 08:24
@alexandre-allard
Copy link
Contributor Author

/reset

@bert-e

This comment has been minimized.

Sign in to view
@bert-e

This comment has been minimized.

Sign in to view
@bert-e

This comment has been minimized.

Sign in to view
Ebaneck
Ebaneck previously approved these changes Jun 15, 2020
View reviewed changes
Copy link
Contributor

@Ebaneck Ebaneck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@Ebaneck
Copy link
Contributor

Ebaneck commented Jun 15, 2020

Agreed to merge this after the release

@gdemonet
Copy link
Contributor

Maybe target 2.6, given it's quite the breaking change @alexandre-allard-scality

Also, can we make sure people involved agree with the "new" design? Naming a few: @MonPote @nicolas2bert @slaperche-scality @rachedbenmustapha

@alexandre-allard
Copy link
Contributor Author

@gdemonet since we already broke the Solutions with the new manifest... I thought we could do everything in the same version. :)

@gdemonet
Copy link
Contributor

Maybe... Better to ask than to hope 😜

@alexandre-allard alexandre-allard force-pushed the improvement/2581-no-longer-deploy-solution-ui branch from e31bebf to c6959d0 Compare August 12, 2020 06:48
@alexandre-allard alexandre-allard changed the base branch from development/2.5 to development/2.6 August 12, 2020 06:48
@alexandre-allard
Copy link
Contributor Author

This PR is now targeting development/2.6

@scality scality deleted a comment from Ebaneck Aug 12, 2020
@bert-e

This comment has been minimized.

Sign in to view
gdemonet
gdemonet suggested changes Aug 12, 2020
View reviewed changes
Copy link
Contributor

@gdemonet gdemonet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add an entry in the CHANGELOG and then merge it :)

@bert-e

This comment has been minimized.

Sign in to view
@alexandre-allard
salt: no longer deploy Solutions admin UIs
dd2c3b2 
It is now the responsibility of the Solution Operators
to deploy their UIs.
We changed this so that the Solution framework is really
minimalistic and Solution developers are free to deploy
and manage the Solution UI how they want.

Refs: #2581
@alexandre-allard
example: remove UI image from Solution manifest
bffe0ad 
Stop generating the ui_image section in the manifest
since the Solution framework no longer handle the
Solution UI deployment.

Refs: #2581
@alexandre-allard
tests: do not check for Solution UI deployment
f9233b1 
Since the UI is optionnal and we no longer deploy
it from the Solution framework, we do not want to
check for its presence as it's not directly related
to the Solution framework anymore.
Plus, this test would break because the Example
Solution has not been adapted yet to deploy its
UI.

Refs: #2581
@alexandre-allard
docs: update solutions doc to remove UI deployment part
56a6742 
Update architecture document and solution developer
guide to remove the part related to the deployment
of Solution UIs because we no longer deploy them.

Refs: #2581
@alexandre-allard alexandre-allard force-pushed the improvement/2581-no-longer-deploy-solution-ui branch from c6959d0 to 56a6742 Compare August 12, 2020 06:58
@alexandre-allard
Copy link
Contributor Author

@gdemonet done in dd2c3b2

@bert-e

This comment has been minimized.

Sign in to view
@alexandre-allard
Copy link
Contributor Author

/approve

@bert-e
Copy link
Contributor

bert-e commented Aug 12, 2020

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/2.6

The following branches will NOT be impacted:

  • development/1.0
  • development/1.1
  • development/1.2
  • development/1.3
  • development/2.0
  • development/2.1
  • development/2.2
  • development/2.3
  • development/2.4
  • development/2.5

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Aug 12, 2020

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/2.6

The following branches have NOT changed:

  • development/1.0
  • development/1.1
  • development/1.2
  • development/1.3
  • development/2.0
  • development/2.1
  • development/2.2
  • development/2.3
  • development/2.4
  • development/2.5

Please check the status of the associated issue None.

Goodbye alexandre-allard-scality.

@bert-e bert-e merged commit 9ea07df into development/2.6 Aug 12, 2020
@bert-e bert-e deleted the improvement/2581-no-longer-deploy-solution-ui branch August 12, 2020 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gdemonet gdemonet gdemonet approved these changes

@Ebaneck Ebaneck Ebaneck left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Solution framework should not deploy Solution UIs
4 participants
@alexandre-allard @bert-e @Ebaneck @gdemonet