Procedure to deploy registry HA #3400

TeddyAndrieux · 2021-05-27T08:59:30Z

Component:

'salt', 'docs', 'tests'

Context:

The first step of bootstrap HA (registry + repository HA)

Summary:

Update the salt module to retrieve Kubernetes endpoint to retrieve the full list of all endpoints and not only a single one.
Configure contained and repo with all repositories endpoints (HA registry and repo)
Add tests for registry
Add procedure to deploy registry container on a second node (HA registry)

See: #2002

bert-e · 2021-05-27T08:59:32Z

Hello teddyandrieux,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

bert-e · 2021-05-27T08:59:37Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

alexandre-allard

First round, wording/typos/etc. :)

docs/operation/registry_ha.rst

alexandre-allard

LGTM.

tests/post/steps/test_registry.py

salt/tests/unit/modules/files/test_metalk8s_kubernetes_utils.yaml

salt/metalk8s/repo/redhat.sls

Update the salt module to retrieve Kubernetes endpoint to retrieve the full list of all endpoints and not only a single one. Update the containerd and repository configuration to support multi endpoint

We may want to configure ISO on differents nodes for registry HA so make sure we have all needed dependencies on all minions

If we try to import a solution where repositories container is not yet deployed, the "expose" state will fail as expected directory does not exists yet. But in case of HA registry we want to run the `solutions.available` state before actual creating the repository container

Add a simple test for registry HA when running on multi node cluster

NicolasT · 2021-06-02T09:33:51Z

docs/operation/registry_ha.rst

+
+  root@bootstrap $ kubectl exec -n kube-system -c salt-master \\
+     --kubeconfig=/etc/kubernetes/admin.conf \\
+     salt-master-bootstrap -- salt '*' state.sls \\


This pod name is not fixed, so this isn't a copy-paste command, even though it looks like one. This needs to be explained.

Agree, but it's not only here, everywhere in the documentation we do this ... which is an issue I agree

That's a bug, cc @thomasdanan

I will replace this one at least

salt/_pillar/metalk8s_endpoints.py

bert-e · 2021-06-02T09:37:27Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

The following reviewers are expecting changes from the author, or must review again:

@NicolasT

The following options are set: approve

docs/operation/registry_ha.rst

Comment handled

bert-e · 2021-06-02T15:05:48Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

Refs: #2002

TeddyAndrieux · 2021-06-02T15:11:41Z

/approve

bert-e · 2021-06-02T16:19:44Z

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

✔️ development/2.10

The following branches will NOT be impacted:

development/2.0
development/2.1
development/2.2
development/2.3
development/2.4
development/2.5
development/2.6
development/2.7
development/2.8
development/2.9

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

Any commit you add on the source branch will trigger a new cycle after the
current queue is merged.
Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

bert-e · 2021-06-02T17:26:19Z

I have successfully merged the changeset of this pull request
into targetted development branches:

✔️ development/2.10

The following branches have NOT changed:

development/2.0
development/2.1
development/2.2
development/2.3
development/2.4
development/2.5
development/2.6
development/2.7
development/2.8
development/2.9

Please check the status of the associated issue None.

Goodbye teddyandrieux.

TeddyAndrieux requested a review from a team May 27, 2021 08:59

TeddyAndrieux force-pushed the improvement/repository-ha branch 11 times, most recently from 61e6b0e to b7c62e4 Compare May 28, 2021 15:14

TeddyAndrieux marked this pull request as ready for review May 28, 2021 16:59

alexandre-allard reviewed Jun 1, 2021

View reviewed changes

TeddyAndrieux force-pushed the improvement/repository-ha branch from b7c62e4 to f051bd0 Compare June 2, 2021 06:56

alexandre-allard reviewed Jun 2, 2021

View reviewed changes

TeddyAndrieux added 4 commits June 2, 2021 10:57

salt: Support multi endpoints for repositories

455afba

Update the salt module to retrieve Kubernetes endpoint to retrieve the full list of all endpoints and not only a single one. Update the containerd and repository configuration to support multi endpoint

salt: Make sure genisoimage is installed everywhere

ec134be

We may want to configure ISO on differents nodes for registry HA so make sure we have all needed dependencies on all minions

tests: Add tests for Registry HA

a26916a

Add a simple test for registry HA when running on multi node cluster

TeddyAndrieux force-pushed the improvement/repository-ha branch from f051bd0 to 7e8d5ea Compare June 2, 2021 09:03

alexandre-allard previously approved these changes Jun 2, 2021

View reviewed changes

NicolasT previously requested changes Jun 2, 2021

View reviewed changes

TeddyAndrieux dismissed alexandre-allard’s stale review via c411c82 June 2, 2021 09:55

TeddyAndrieux force-pushed the improvement/repository-ha branch from 7e8d5ea to c411c82 Compare June 2, 2021 09:55

TeddyAndrieux mentioned this pull request Jun 2, 2021

Remove "workaround" for pillar endpoints backward compatiblity #3413

Closed

alexandre-allard reviewed Jun 2, 2021

View reviewed changes

docs/operation/registry_ha.rst Outdated Show resolved Hide resolved

TeddyAndrieux added 2 commits June 2, 2021 17:08

docs: Add registry HA procedure

f9ff7b3

Refs: #2002

changelog: Add entry for registry HA

12371a8

TeddyAndrieux force-pushed the improvement/repository-ha branch from c411c82 to 12371a8 Compare June 2, 2021 15:08

alexandre-allard approved these changes Jun 2, 2021

View reviewed changes

bert-e merged commit 6808653 into development/2.10 Jun 2, 2021

bert-e deleted the improvement/repository-ha branch June 2, 2021 17:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Procedure to deploy registry HA #3400

Procedure to deploy registry HA #3400

TeddyAndrieux commented May 27, 2021 •

edited

Loading

bert-e commented May 27, 2021

bert-e commented May 27, 2021

alexandre-allard left a comment

alexandre-allard left a comment

NicolasT Jun 2, 2021

TeddyAndrieux Jun 2, 2021

NicolasT Jun 2, 2021

TeddyAndrieux Jun 2, 2021

bert-e commented Jun 2, 2021

bert-e commented Jun 2, 2021

TeddyAndrieux commented Jun 2, 2021

bert-e commented Jun 2, 2021

bert-e commented Jun 2, 2021

Procedure to deploy registry HA #3400

Procedure to deploy registry HA #3400

Conversation

TeddyAndrieux commented May 27, 2021 • edited Loading

bert-e commented May 27, 2021

Hello teddyandrieux,

bert-e commented May 27, 2021

Waiting for approval

alexandre-allard left a comment

Choose a reason for hiding this comment

alexandre-allard left a comment

Choose a reason for hiding this comment

NicolasT Jun 2, 2021

Choose a reason for hiding this comment

TeddyAndrieux Jun 2, 2021

Choose a reason for hiding this comment

NicolasT Jun 2, 2021

Choose a reason for hiding this comment

TeddyAndrieux Jun 2, 2021

Choose a reason for hiding this comment

bert-e commented Jun 2, 2021

Waiting for approval

bert-e commented Jun 2, 2021

Waiting for approval

TeddyAndrieux commented Jun 2, 2021

bert-e commented Jun 2, 2021

In the queue

bert-e commented Jun 2, 2021

TeddyAndrieux commented May 27, 2021 •

edited

Loading