Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use webpack module federation to aggregate UIs and solutions UIs #3414

Merged
merged 89 commits into from
Jul 7, 2021
Merged

Use webpack module federation to aggregate UIs and solutions UIs #3414

merged 89 commits into from
Jul 7, 2021

Conversation

JBWatenbergScality
Copy link
Contributor

@JBWatenbergScality JBWatenbergScality commented Jun 4, 2021 •
edited
Loading

Component:

ui

Context:

We are studying options to improve overall user experience while browsing the UI when several solutions UI are deployed and registered in the common navbar configuration.

Summary:

This PR introduces a set of changes to convert the common navbar to a bidirectional federated host (https://github.com/module-federation/module-federation-examples/tree/master/bi-directional) that can load UI remote bundle at runtime and hence be able to render an UI depending on a dynamic context where new solutions can be deployed / upgraded independently than the Metalk8s Shell-UI

Acceptance criteria:

End2End tests, documentation and design docs should be released.

@bert-e
Copy link
Contributor

bert-e commented Jun 4, 2021

Hello jbwatenbergscality,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@JBWatenbergScality JBWatenbergScality force-pushed the improvement/shell-ui-switch-to-module-federation branch from ce37460 to 489648a Compare June 7, 2021 07:43
@bert-e
Copy link
Contributor

bert-e commented Jun 7, 2021

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@scality scality deleted a comment from bert-e Jun 7, 2021
@JBWatenbergScality JBWatenbergScality force-pushed the improvement/shell-ui-switch-to-module-federation branch 5 times, most recently from 4660acd to 536d1db Compare June 28, 2021 14:58
@ChengYanJin ChengYanJin force-pushed the improvement/shell-ui-switch-to-module-federation branch 2 times, most recently from aaa9ca1 to b7827e9 Compare June 28, 2021 15:24
@JBWatenbergScality JBWatenbergScality force-pushed the improvement/shell-ui-switch-to-module-federation branch 3 times, most recently from 05ba155 to 7021156 Compare June 28, 2021 22:46
@bert-e
Copy link
Contributor

bert-e commented Jul 1, 2021

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@ChengYanJin ChengYanJin force-pushed the improvement/shell-ui-switch-to-module-federation branch 2 times, most recently from f287d2a to c683b7f Compare July 4, 2021 14:20
@JBWatenbergScality JBWatenbergScality force-pushed the improvement/shell-ui-switch-to-module-federation branch 5 times, most recently from 0ecd24e to 8019b35 Compare July 5, 2021 22:39
@JBWatenbergScality JBWatenbergScality changed the title [WIP] Use webpack module federation to aggregate UIs and solutions UIs Use webpack module federation to aggregate UIs and solutions UIs Jul 6, 2021
@JBWatenbergScality JBWatenbergScality marked this pull request as ready for review July 6, 2021 07:46
@JBWatenbergScality JBWatenbergScality requested a review from a team as a code owner July 6, 2021 07:46
@bert-e
Copy link
Contributor

bert-e commented Jul 6, 2021

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@JBWatenbergScality JBWatenbergScality force-pushed the improvement/shell-ui-switch-to-module-federation branch 2 times, most recently from d5b7c20 to aeb1b6f Compare July 6, 2021 15:46
JBWatenbergScality and others added 23 commits July 7, 2021 12:29
@JBWatenbergScality
ui: Use config from runtime app config web finger instead of refetchi…
5cc0757 
…ng it from /config.json
@JBWatenbergScality
salt: Runtime app configuration
fdb21a7
@JBWatenbergScality
ui: Create voume, remove unnecessary intl.formatMessage
dde5678
@JBWatenbergScality
salt: CSC framework for deployed ui apps
d5eeb13
@JBWatenbergScality
shell: Webpack add entry.js in bundled index.html
b777e3c
@JBWatenbergScality
shell-ui: Bump module federation library
3751631
@JBWatenbergScality
ci: fixes
748ca30
@JBWatenbergScality
ui: Use shell index.html for local dev
a1a694a
@JBWatenbergScality
ui: Upgrade react-query to support module federation context sharing
8bf778d
@JBWatenbergScality
shell: Add an error boundary in case of error while rendering a micro…
45c9c00 
… app
@JBWatenbergScality
shell: Attach shared context to the window to enable micro apps to re…
0deb434 
…sue them
@JBWatenbergScality
shell: Import css and font
c0cea5e
@JBWatenbergScality
ui: Fix integration test
1974714
@JBWatenbergScality
ui: Fetch the app runtime config before fetching the basename
044e94a
@ChengYanJin @JBWatenbergScality
shell-ui: Expose the UIListProvider module
32ffb0d
@ChengYanJin @JBWatenbergScality
ui: Expose the platform library
3c28bb8
@JBWatenbergScality
shell,ui: bump module federation library
58b809e
@JBWatenbergScality
docs: Update developer docs to run the UI locally
ccd1774
@JBWatenbergScality
changelog: Add an entry referring module federation changes
cb1e262
@JBWatenbergScality
ui: Expose /config.json configuration for backward compatibility
6b3141c
@JBWatenbergScality
shell: Introduce a ShellHistoryProvider to enable use of useLinkOpene…
8c28201 
…r in micor apps using react router
@JBWatenbergScality
ui,salt,shell: Add backward compatibility for alerts and platform lib…
1a2a90f 
…raries
@JBWatenbergScality
shell: Fix selected tab for non federated entries
7389da7
@JBWatenbergScality JBWatenbergScality force-pushed the improvement/shell-ui-switch-to-module-federation branch from b09f04e to 7389da7 Compare July 7, 2021 10:33
@JBWatenbergScality
Copy link
Contributor Author

/approve

@bert-e
Copy link
Contributor

bert-e commented Jul 7, 2021

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/2.10

The following branches will NOT be impacted:

  • development/2.0
  • development/2.1
  • development/2.2
  • development/2.3
  • development/2.4
  • development/2.5
  • development/2.6
  • development/2.7
  • development/2.8
  • development/2.9

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Jul 7, 2021

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/2.10

The following branches have NOT changed:

  • development/2.0
  • development/2.1
  • development/2.2
  • development/2.3
  • development/2.4
  • development/2.5
  • development/2.6
  • development/2.7
  • development/2.8
  • development/2.9

Please check the status of the associated issue None.

Goodbye jbwatenbergscality.

@bert-e bert-e merged commit 7389da7 into development/2.10 Jul 7, 2021
@bert-e bert-e deleted the improvement/shell-ui-switch-to-module-federation branch July 7, 2021 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChengYanJin ChengYanJin ChengYanJin approved these changes

@MonPote MonPote Awaiting requested review from MonPote

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JBWatenbergScality @bert-e @ChengYanJin