ui: Bugfix salt redux store #3477
Conversation
…lting in the state parameter to be null and failling to proceed. This commit replace call by select which is the right function to call for selectors
While working on the UI I met the following error :
```
TypeError: Cannot read property 'return' of undefined
at getJobStatusFromPrintJob (utils.js:89)
at refreshJobStatus$ (salt.js:188)
```
This is due to the fact that salt API was returning an empty object in `Result`.
Below is the row result given by salt API.
```json
{
"return": [
{
"20210802092226728983": {
"Error": "Cannot contact returner or no job with this jid",
"StartTime": "2021, Aug 02 09:22:26.728983",
"Result": {}
}
}
]
}
This commit is checking wether the `Result` object is empty before trying to parse the error.
```
Hello jbwatenbergscality,My role is to assist you with the merge of this Status report is not available. |
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
Peer approvals must include at least 1 approval from the following list:
|
JBWatenbergScality
changed the base branch from
development/2.11
to
development/2.10
Integration data createdI have created the integration data for the additional destination branches.
The following branches will NOT be impacted:
You can set option |
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
Peer approvals must include at least 1 approval from the following list:
|
|
/approve |
Build failedThe build for commit did not succeed in branch w/2.11/bugfix/salt-error-management. The following options are set: approve |
In the queueThe changeset has received all authorizations and has been added to the The changeset will be merged in:
The following branches will NOT be impacted:
There is no action required on your side. You will be notified here once IMPORTANT Please do not attempt to modify this pull request.
If you need this pull request to be removed from the queue, please contact a The following options are set: approve |
|
I have successfully merged the changeset of this pull request
The following branches have NOT changed:
Please check the status of the associated issue None. Goodbye jbwatenbergscality. |
Component:
ui
Context:
After playing with node deployment feature on the UI I spot several bugs that this PR is fixing.
Summary: