UI: Fetch alert history #3501

JBWatenbergScality · 2021-08-19T13:54:42Z

Component:

ui

Context:

In order to display the Global health component we have to provide a way for the UI to retrieve alert history.

Summary:

This PR improve the behavior of useHistoryAlert to take in account platform downTimes.

Acceptance criteria:

Unit testing

bert-e · 2021-08-19T13:54:44Z

Hello jbwatenbergscality,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

bert-e · 2021-08-19T13:54:48Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

bert-e · 2021-09-21T07:59:14Z

Conflict

There is a conflict between your branch improvement/ui-alert-history and the
destination branch development/2.11.

Please resolve the conflict on the feature branch (improvement/ui-alert-history).

git fetch && \
git checkout origin/improvement/ui-alert-history && \
git merge origin/development/2.11

Resolve merge conflicts and commit

git push origin HEAD:improvement/ui-alert-history

ChengYanJin

I just have some requests to write some comments to help us to remember the issue we faced...

And thanks for rebasing to my branch again, it was not very clean before :/

ChengYanJin · 2021-09-22T14:00:32Z

ui/src/containers/Layout.js

-            exact
-            path="/"
-            component={() => <Redirect to="/nodes" />}
+        <AlertHistoryProvider>


I am just wondering should we wrap this AlertHisotryProvider in App.js?

ChengYanJin · 2021-09-22T16:17:21Z

ui/src/translations/en.json

@@ -176,5 +176,6 @@
  "core": "Core",
  "view_details": "View details",
  "start": "Start",
-  "no_data_available_for_metrics": "No data available for displaying the Metrics"
+  "no_data_available_for_metrics": "No data available for displaying the Metrics",
+  "global_health_explanation": "The Global Health is the overall status of your Platform over a specific period.\nThe statuses of the Volumes and Nodes, the Network and the Services are monitored.\n(circle with StatusHealthy) OK, the Platform is healthy.\n(circle with StatusWarning) Warning, the Platform is degraded but not at risk.\n(circle with StatusCritical) Critical status, the Platform is degraded and at risk.\nHover or click on an alert segment on the Global Health bar for more details."


I guess we don't have a french translation for this long text yet?

ChengYanJin · 2021-09-22T20:25:31Z

ui/src/services/loki/api.js

@@ -46,7 +48,7 @@ export function getAlertsLoki(start: string, end: string): Promise<Alert[]> {

  return lokiApiClient
    .get(
-      `/loki/api/v1/query_range?start=${start}&end=${end}&query=${METALK8S_HISTORY_ALERTS_QUERY}`,
+      `/loki/api/v1/query_range?start=${start}&end=${end}&limit=1000&query=${METALK8S_HISTORY_ALERTS_QUERY}`,


can we write down the reason why we set the limit to 1000?

ChengYanJin · 2021-09-22T20:44:51Z

ui/src/containers/DashboardPage.js

@@ -122,11 +113,15 @@ const DashboardPage = (props: {}) => {
    onClick: () => {
      writeUrlTimeSpan(option);
    },
-    selected: queryTimeSpansCodes.find(timespan => timespan.duration === metricsTimeSpan)?.label === option,
+    selected:
+      queryTimeSpansCodes.find((item) => item.label === label)?.label ===


Just FYI:
I exposed the queryTimeSpansCodes from core-ui as well ;) To make sure we have a single source of truth.

ChengYanJin · 2021-09-22T20:47:52Z

ui/src/containers/StartTimeProvider.js

-    const newCurrentDate = new Date();
-    setCurrentTime(newCurrentDate);
+    const newCurrentDate = new Date().getTime();
+    const newCurrentTime = newCurrentDate - (newCurrentDate % (frequency * 1000));


I think here it worth writiing down why we did this change (what problem we were trying to solve)

bert-e · 2021-09-23T08:48:29Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

bert-e · 2021-09-28T13:56:01Z

Conflict

There is a conflict between your branch improvement/ui-alert-history and the
destination branch development/2.11.

Please resolve the conflict on the feature branch (improvement/ui-alert-history).

git fetch && \
git checkout origin/improvement/ui-alert-history && \
git merge origin/development/2.11

Resolve merge conflicts and commit

git push origin HEAD:improvement/ui-alert-history

… avoid whole displayed charts to change over time and simulate an effect where new entries move the charts to the right

…is smaller than 12 hours

Remove the ServiceItem from DashboardServices and create the HealthItem component with it Add DashboardPlane component containing 2 HealthItems Add tests for the new DashbordPlane component history.push replaced by history.replace in the HealthItem component Ref: #3511

…k call

bert-e · 2021-09-28T14:53:17Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

JBWatenbergScality · 2021-09-29T08:07:37Z

/approve

bert-e · 2021-09-29T08:07:43Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

The following options are set: approve

ChengYanJin

LGTM!

bert-e · 2021-09-29T08:07:55Z

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

✔️ development/2.11

The following branches will NOT be impacted:

development/2.0
development/2.1
development/2.10
development/2.2
development/2.3
development/2.4
development/2.5
development/2.6
development/2.7
development/2.8
development/2.9

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

Any commit you add on the source branch will trigger a new cycle after the
current queue is merged.
Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

bert-e · 2021-09-29T08:08:01Z

I have successfully merged the changeset of this pull request
into targetted development branches:

✔️ development/2.11

The following branches have NOT changed:

development/2.0
development/2.1
development/2.10
development/2.2
development/2.3
development/2.4
development/2.5
development/2.6
development/2.7
development/2.8
development/2.9

Please check the status of the associated issue None.

Goodbye jbwatenbergscality.

JBWatenbergScality requested a review from a team as a code owner August 19, 2021 13:54

JBWatenbergScality force-pushed the improvement/ui-alert-history branch from e10319e to d25dbdb Compare September 21, 2021 07:59

JBWatenbergScality changed the base branch from development/2.11 to feature/replace-the-metrics-charts-with-the-new-linetemporalchart September 21, 2021 08:00

ChengYanJin force-pushed the feature/replace-the-metrics-charts-with-the-new-linetemporalchart branch from 45c1ab9 to bb64655 Compare September 21, 2021 08:08

JBWatenbergScality force-pushed the improvement/ui-alert-history branch 3 times, most recently from 25eb470 to 4fc7988 Compare September 22, 2021 08:41

ChengYanJin force-pushed the feature/replace-the-metrics-charts-with-the-new-linetemporalchart branch 2 times, most recently from 2936a76 to eb78221 Compare September 22, 2021 09:07

JBWatenbergScality force-pushed the improvement/ui-alert-history branch 3 times, most recently from c495b8e to 611469e Compare September 22, 2021 14:46

ChengYanJin force-pushed the feature/replace-the-metrics-charts-with-the-new-linetemporalchart branch from c503a5b to 7a3aeff Compare September 22, 2021 16:09

ChengYanJin reviewed Sep 22, 2021

View reviewed changes

Base automatically changed from feature/replace-the-metrics-charts-with-the-new-linetemporalchart to development/2.11 September 23, 2021 07:49

JBWatenbergScality force-pushed the improvement/ui-alert-history branch from 611469e to d184ffa Compare September 23, 2021 08:48

JBWatenbergScality mentioned this pull request Sep 23, 2021

ARTESCA-1878: Dashboard Network Plane Health #3522

Closed

ChengYanJin previously approved these changes Sep 23, 2021

View reviewed changes

JBWatenbergScality dismissed ChengYanJin’s stale review via afd040f September 24, 2021 13:41

JBWatenbergScality force-pushed the improvement/ui-alert-history branch 2 times, most recently from afd040f to de57104 Compare September 24, 2021 14:55

ChengYanJin force-pushed the improvement/ui-alert-history branch from 9bb6a9e to 2a2e3ea Compare September 28, 2021 14:44

JBWatenbergScality added 3 commits September 28, 2021 16:53

docs: Document how UI retrieves alert history

e9171ae

ui: Add support for downtime to useHistoryAlerts

2d25ebb

ui: Use redux config in Dashboard page

e651f0d

JBWatenbergScality and others added 15 commits September 28, 2021 16:53

ui: Implement global health component in Dashboard page

64076c3

ui: Add alert history hooks tests

b6fda57

dashboard: Global Health Component layout

72f1201

charts: Synchronize start time and end time on the chart frequency to…

5333daf

… avoid whole displayed charts to change over time and simulate an effect where new entries move the charts to the right

ui: alerts provider: support no currently raised alerts

5e5644c

globalhealth: Add support for long running alerts when the time span …

f619274

…is smaller than 12 hours

dashboardpage: Fix wrong margin value

89447fc

dashboardpage: Remove unnecessary extra Synced Cursor component

26f8de5

ui: Replace queryTimeSpansCodes by core-ui one

699d805

ui: test of node partition table warn in case of unintercepted networ…

286884f

…k call

ui: Extract the timespan selector

307ff59

ui: Add loki url to local configuration

212dc95

ui: Fix dashboard page timespan selector

2b70a61

ui: Fix metric time span selector issues

797706f

JBWatenbergScality force-pushed the improvement/ui-alert-history branch from 2a2e3ea to 797706f Compare September 28, 2021 14:53

test: Mock loki endpoint in Node partition table test

dbff559

ChengYanJin approved these changes Sep 29, 2021

View reviewed changes

bert-e merged commit dbff559 into development/2.11 Sep 29, 2021

bert-e deleted the improvement/ui-alert-history branch September 29, 2021 08:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

UI: Fetch alert history #3501

UI: Fetch alert history #3501

JBWatenbergScality commented Aug 19, 2021

bert-e commented Aug 19, 2021

bert-e commented Aug 19, 2021

bert-e commented Sep 21, 2021

ChengYanJin left a comment •

edited

Loading

ChengYanJin Sep 22, 2021

ChengYanJin Sep 22, 2021

ChengYanJin Sep 22, 2021

ChengYanJin Sep 22, 2021

ChengYanJin Sep 22, 2021

bert-e commented Sep 23, 2021

bert-e commented Sep 28, 2021

bert-e commented Sep 28, 2021

JBWatenbergScality commented Sep 29, 2021

bert-e commented Sep 29, 2021

ChengYanJin left a comment

bert-e commented Sep 29, 2021

bert-e commented Sep 29, 2021

UI: Fetch alert history #3501

UI: Fetch alert history #3501

Conversation

JBWatenbergScality commented Aug 19, 2021

bert-e commented Aug 19, 2021

Hello jbwatenbergscality,

bert-e commented Aug 19, 2021

Waiting for approval

bert-e commented Sep 21, 2021

Conflict

ChengYanJin left a comment • edited Loading

Choose a reason for hiding this comment

ChengYanJin Sep 22, 2021

Choose a reason for hiding this comment

ChengYanJin Sep 22, 2021

Choose a reason for hiding this comment

ChengYanJin Sep 22, 2021

Choose a reason for hiding this comment

ChengYanJin Sep 22, 2021

Choose a reason for hiding this comment

ChengYanJin Sep 22, 2021

Choose a reason for hiding this comment

bert-e commented Sep 23, 2021

Waiting for approval

bert-e commented Sep 28, 2021

Conflict

bert-e commented Sep 28, 2021

Waiting for approval

JBWatenbergScality commented Sep 29, 2021

bert-e commented Sep 29, 2021

Waiting for approval

ChengYanJin left a comment

Choose a reason for hiding this comment

bert-e commented Sep 29, 2021

In the queue

bert-e commented Sep 29, 2021

ChengYanJin left a comment •

edited

Loading