New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

environment checks do not handle conditions with multiple logical expressions #2

Closed

scalvert opened this issue Jan 3, 2017 · 0 comments

Owner

scalvert commented Jan 3, 2017

Combining logical expressions in a condition result in the linting rule firing:

if (environment.isBrowser() && this.get('screenPoly.fullScreenChange')) {
    document.addEventListener(
      this.get('screenPoly.fullScreenChange'),
      this.get('_boundHandleFullScreenChange')
    )
}

The workaround was:

if (this.get('screenPoly.fullScreenChange')) {
  if (environment.isBrowser()){
      document.addEventListener(
        this.get('screenPoly.fullScreenChange'),
        this.get('_boundHandleFullScreenChange')
      );
  }
}

scalvert mentioned this issue

[Fix] - environment checks don't handle conditions with multiple expressions #3

Merged

scalvert closed this as completed in #3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment