Adopt GHA Scala Library Release Workflow #1769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As mentioned in #1763, we're switching to use `gha-scala-library-release-workflow` for releasing the Scanamo to Maven Central. This is a change from the release process based on `sbt-ci-release` that was introduced with #280 - it used to be that to trigger a release, we would push a git tag with a manually-selected version number (eg `v1.0.3`), the new process is now to run the `Release` workflow manually, which will automatically determine a version number based on the binary-compatibility checks performed by `sbt-version-policy`. In order to do this, we've had to follow the one-off organisation-setup steps in: https://github.com/guardian/gha-scala-library-release-workflow/blob/main/docs/org-setup.md ...which included creating a GitHub App for the Scanamo organisation: https://github.com/apps/scala-library-release-scanamo Additionally, this PR contains the per-repo modifications required by: https://github.com/guardian/gha-scala-library-release-workflow/blob/main/docs/configuration.md
rtyley
commented
Apr 1, 2024
| publishingSettings, | ||
| noPublishSettings, | ||
| publish / skip := true, | ||
| // releaseVersion := ReleaseVersion.fromAggregatedAssessedCompatibilityWithLatestRelease().value, |
There was a problem hiding this comment.
This had to be disabled due to v1.0.2 failing and guardian/gha-scala-library-release-workflow#33
rtyley
added a commit
that referenced
this pull request
Apr 1, 2024
Following on from #1769, and as mentioned in: https://github.com/guardian/gha-scala-library-release-workflow/blob/main/docs/configuration.md#recommended-sbt-settings ...unfortunately it's difficult to figure out how to modify gha-scala-library-release-workflow to start the DynamodDB Local instance to get tests to pass. So, either we modify Scanamo's sbt build to automatically start the DynamodDB Local instance when the tests start - or we just skip tests during release right now.
rtyley
added a commit
that referenced
this pull request
Apr 1, 2024
As mentioned in #1769 (review), when we adopted `gha-scala-library-release-workflow` in #1769 we couldn't immediately enable syntactic-compatibility-checking as the previous release (v1.0.2) had failed.
|
After ce12e44 & d777c21, releases are working well 👍 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #1763, we're switching to use
gha-scala-library-release-workflowfor releasing the Scanamo to Maven Central. This is a change from the release process based onsbt-ci-releasethat was introduced with #280 - it used to be that to trigger a release, we would push a git tag with a manually-selected version number (egv1.0.3), the new process is now to run theReleaseworkflow manually, which will automatically determine a version number based on the version-compatibility checks performed bysbt-version-policy.In order to do this, we've had to follow the one-off organisation-setup steps in:
https://github.com/guardian/gha-scala-library-release-workflow/blob/main/docs/org-setup.md
...which included creating a GitHub App for the Scanamo organisation:
https://github.com/apps/scala-library-release-scanamo
Additionally, this PR contains the per-repo modifications required by:
https://github.com/guardian/gha-scala-library-release-workflow/blob/main/docs/configuration.md
Remaining steps