[WIP] filter query results #96
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
they don't seem handled correctly yet
|
Sorry I haven't had a chance to look at this properly yet. |
|
Could we also add filters on scans |
|
@nemccarthy I'd certainly favour a solution which worked for scans as well as queries. Hoping to get some time to have a proper look at this soon. |
|
this mainly a first try to get a feeling how things should be done in order to get the filters working. Once that done it should not be a problem to add them for the scans |
|
Sorry @ayoub-benali, I meant to try and provide some proper feedback on this, but ended up going in quite a different direction, which resulted in #102 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This an attempt to fix #42
For the moment I added 'andFilter' clause and AndFilterCondition class but they don't seem handled correctly yet.
@philwills I would need some pointers if possible to know why my
andFilter('stuff >= 1)in the tests isn't picked up by the implicits :/The query example that I added in the test is always a
KeyEquals