Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in spec_evaluator.py #525

Closed
leonardomaier opened this issue Feb 2, 2022 · 3 comments · Fixed by #527
Closed

Fix typos in spec_evaluator.py #525

leonardomaier opened this issue Feb 2, 2022 · 3 comments · Fixed by #527
Labels
Documentation Improvements or additions to documentation Good First Issue Good for newcomers or first time contributors.

Comments

@leonardomaier
Copy link
Contributor

leonardomaier commented Feb 2, 2022

File: spec_evaluator.py

    @classmethod
    def filter_response_var(cls, spec_vars):
        """Returns a copy pf ``spec_vars`` without 'response' references.
        Any items with a ``response.*`` reference in their value are left out.
        Returns:
            [dict]: filtered dictionary.
        """
        pattern = re.compile(r"(?:(\s*response\.\w+))")
        return {k: v for k, v in spec_vars.items() if not pattern.search(v)}

Update docstring typo in the classmethod Returns a copy pf -> Returns a copy of

@Pradhvan Pradhvan added Good First Issue Good for newcomers or first time contributors. Documentation Improvements or additions to documentation labels Feb 2, 2022
@Pradhvan
Copy link
Member

Pradhvan commented Feb 2, 2022

@leonardomaier thank you for opening the issue. I just updated the issue. I hope you don't mind. 😄

@leonardomaier
Copy link
Contributor Author

leonardomaier commented Feb 2, 2022

@leonardomaier thank you for opening the issue. I just updated the issue. I hope you don't mind. 😄

No problem, it looks a way better, I'm gonna update another issue I've created to follow this pattern 😄

@leonardomaier
Copy link
Contributor Author

Done in #527 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Improvements or additions to documentation Good First Issue Good for newcomers or first time contributors.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants