Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --insecure flag in curl based on request options #555

Merged
merged 2 commits into from Mar 2, 2023

Conversation

Crocmagnon
Copy link
Contributor

@Crocmagnon Crocmagnon commented Nov 21, 2022

Description

Add the --insecure flag in curl based on request options

Motivation behind this PR?

Closes #554

What type of change is this?

Bug fix

Checklist

  • I have added a changelog entry / my PR does not need a new changelog entry. Instructions.
  • I have added/updated unit tests. Instructions.
  • New and existing unit tests pass locally with my changes. Instructions
  • I have self-documented code my changes by adding docstring(s) and comment(s). Instructions
  • Current PR does not significantly decrease the code coverage and docstring coverage.
  • My code follows the style guidelines of this project.
  • I have run ScanAPI locally and manually tested my changes. Instructions.
  • I have squashed my commits. Instructions.

Issue

Closes #554

@Crocmagnon
Copy link
Contributor Author

Crocmagnon commented Nov 21, 2022

I didn't find any tests covering curl generation, so I wasn't sure where to start or whether they were necessary.

Please advise :)

I've updated some tests though.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for supporting ScanAPI, and congratulations on your first contribution! A project committer will shortly review your contribution.

In the mean time, if you haven't had a chance please skim over the First Pull Request Guide which all pull requests must adhere to.

We hope to see you around!

@github-actions github-actions bot added the First Contribution First contribution to the project. label Nov 21, 2022
Copy link
Member

@camilamaia camilamaia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Crocmagnon, great catch and thanks for the fix!

Indeed, we don't have tests for the template yet, so the ones you added are enough for now. 👍

@camilamaia camilamaia merged commit 466c38b into scanapi:main Mar 2, 2023
@camilamaia
Copy link
Member

@Crocmagnon Congrats on your first PR merged! 🌟 Thank you very much!

I am going to send you an invite to join the ScanAPI org on GitHub 🚀 We invite everyone that has contributed with a merged PR in any of our repositories. Here you can check our Contributing Guidelines so you can understand better how it works.

Check your email/GitHub notifications to find the invite. If you accept it, you will also be able to clone directly our repositories, without needing to fork them.

Welcome on board and once again, thank you! 🙇‍♀️

@camilamaia camilamaia mentioned this pull request Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First Contribution First contribution to the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

curl generation doesn't take verify: false into account
2 participants