Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature - 4px base font size #162

Merged
merged 7 commits into from
Nov 12, 2020
Merged

Feature - 4px base font size #162

merged 7 commits into from
Nov 12, 2020

Conversation

mmexvr
Copy link
Member

@mmexvr mmexvr commented Nov 11, 2020

Describe pull-request
Describe what the pull-request is about
Changes have been made in corporate-ui-site scania/corporate-ui-site#109 and corporate-ui scania/corporate-ui#595
Adapt all the styling to follow 4px grid

  • Font-size 4px in :root
  • All components should look the same
  • Alert have sizing from bootstrap, so no new changed have been added

Classes that use rem as a unit from bootstrap have been effected but not fixed, since it is specific bootstrap classes

  • margin-top (mt), mb, mr and ml classes have not been set to the previous size
  • Padding classes same as margin

Solving issue
Add which issue this pull-request solves by adding # plus the number of the issue (for example #123)
Fixes: #158

How to test
Add description how to test if possible
Should look the same as previous, only the unit have changed

  • Run the corporate-ui-site and look at all the components

Screenshots
If applicable, add screenshots to help explain

Additional context
Add any other context about the pull-request here.

@mmexvr mmexvr added the Feature New feature or request label Nov 11, 2020
@mmexvr mmexvr self-assigned this Nov 11, 2020
@mmexvr mmexvr marked this pull request as draft November 11, 2020 08:17
@mmexvr mmexvr marked this pull request as ready for review November 11, 2020 11:47
Copy link
Contributor

@helloimela helloimela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@helloimela helloimela merged commit a5def5b into master Nov 12, 2020
@helloimela helloimela deleted the feature/4px_base_font-size branch January 22, 2021 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature - Update base font size according to the new spacing design
2 participants