Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3 patch #93

Merged
merged 1 commit into from
Nov 26, 2017
Merged

S3 patch #93

merged 1 commit into from
Nov 26, 2017

Conversation

qianl15
Copy link
Contributor

@qianl15 qianl15 commented Nov 21, 2017

(Sorry I screwed up the last pull request, so I reopened a new one.)
Try to add S3 storage support for Scanner. Also need to update storehouse package.

In order to use S3, the user needs to provide aws_access_key_id and aws_screte_access_key:

export AWS_ACCESS_KEY_ID=<Access Key>
export AWS_SECRET_ACCESS_KEY=<Secret>

And a demo of ~/.scanner.toml file to use S3:

[storage]
type = "s3"
bucket = "<your bucket name>"
db_path = "scanner_db"
region = "us-west-2(change to your S3 bucket region)"
endpoint = "s3.dualstack.us-west-2.amazonaws.com (change to your S3 endpoint)"

@fpoms
Copy link
Contributor

fpoms commented Nov 25, 2017

@qinglan233: can you rebase onto the most recent master? We've pushed a fix that should fix the travis build failing for PRs.

@qianl15
Copy link
Contributor Author

qianl15 commented Nov 25, 2017

The travis build returns:

Error response from daemon: No such image: scannerresearch/scanner:cpu

Have no idea...

@fpoms
Copy link
Contributor

fpoms commented Nov 25, 2017

@qinglan233: sorry, this should be fixed now. Please try rebasing again!

@fpoms
Copy link
Contributor

fpoms commented Nov 25, 2017

@qinglan233: Ugh, sorry, working with Travis can be a pain sometimes... trying a fix for this new issue now.

@qianl15 qianl15 force-pushed the s3-patch branch 2 times, most recently from 66b9a49 to 55d8355 Compare November 26, 2017 00:29
add s3 support

Pass region and endpoint to s3 config

Restore thirdparty/CMakeLists.txt and 00_basic.py

Restore thirdparty/CMakeLists.txt and 00_basic.py
@fpoms fpoms merged commit 6d8f69d into scanner-research:master Nov 26, 2017
@fpoms
Copy link
Contributor

fpoms commented Nov 26, 2017

Closes #87

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants