This repository has been archived by the owner on Nov 29, 2020. It is now read-only.
fix crash if output has no margins #270
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It crashes on line 255. The problem must be with rounding rectangles in float coordinates to rectangles in integer coordinates. In some circumstances it rounds to -1 pixel for output rect and to +1 pixel for working rect. Working rect size becomes 1 pixel bigger than output page size and everything collapses. And non-zero margins seems to save ST from that. toAlignedRect() is using ceil() instead of round() for float coordinates conversion so the sizes should always match.
Sometimes `toAlignedRect` may return rect with coordinate < 0.0. Made additional checks for that.
atla5
reviewed
Jul 18, 2017
| { | ||
| int dy = -1*m_contentRect.top(); | ||
| m_outRect.adjust(0,0,0,dy); // size increase | ||
| m_contentRect.adjust(0,dy,0,dy); // shift |
There was a problem hiding this comment.
wondering if it might increase readability to use <cmath>.abs instead of multiplying this by -1.
what are your thoughts?
There was a problem hiding this comment.
I've no preferences in this case. You can change this if you want or let me know if you want me to do this.
|
found same issue with m_outRect. So made the checks for it too here. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #210
ST crashes on line 255.
The problem must be with rounding rectangles in float coordinates to rectangles in integer coordinates. In some circumstances it rounds to -1 pixel for output rect and to +1 pixel for working rect. Working rect size becomes 1 pixel bigger than output page size and everything collapses. And non-zero margins seems to save ST from that. toAlignedRect() is using ceil() instead of round() for float coordinates conversion so the sizes should always match.