Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make Mini-Hakkero visually less obtrusive #173

Merged
merged 1 commit into from
Mar 27, 2023
Merged

feat: make Mini-Hakkero visually less obtrusive #173

merged 1 commit into from
Mar 27, 2023

Conversation

scarf005
Copy link
Owner

@scarf005 scarf005 changed the title feat: disable mini hakkero flashing on using card feat: make Mini-Hakkero visually less obtrusive Mar 27, 2023
@scarf005 scarf005 merged commit 600f1ee into main Mar 27, 2023
2 checks passed
@scarf005 scarf005 deleted the no-flashy-hakkero branch March 27, 2023 13:34
@erasels
Copy link

erasels commented Mar 27, 2023

Oh, uh looking at the changes you removed the relic flash not the RelicAboveCreatureAction, I may have not been specific enough.
The flash isn't very obstrusive since that only affected the relic image at the top of the screen. I was talking about the relic hovering above the player's model for a second every time you play a card.

@scarf005
Copy link
Owner Author

...oh, ...um, the thing is i never noticed relics hovering until this whole time...
i'll revert the commit and fix them tomorrow.

scarf005 added a commit that referenced this pull request Apr 14, 2023
@scarf005
revert: "feat: make Mini-Hakkero visually less obtrusive (#173)"
f54ef34 
@erasels request was to remove `RelicAboveCreatureAction` for hakkeros, but instead `flash` was removed.

This reverts commit 600f1ee.
scarf005 added a commit that referenced this pull request Apr 14, 2023
@scarf005
feat: disable mini hakkero hovering on using card
ee7aced 
discussed in: #173 (comment)
@scarf005 scarf005 mentioned this pull request Apr 14, 2023
Merged
scarf005 added a commit that referenced this pull request Apr 14, 2023
@scarf005
fix: prevent Mini-Hakkero from hovering when using cards (#178)
fefc4bc 
* revert: "feat: make Mini-Hakkero visually less obtrusive (#173)"

@erasels request was to remove `RelicAboveCreatureAction` for hakkeros, but instead `flash` was removed.

This reverts commit 600f1ee.

* feat: disable mini hakkero hovering on using card

discussed in: #173 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make MiniHakkero visually less obtrusive
2 participants
@scarf005 @erasels