Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(L10n): translate powers (JPN) #183

Merged
merged 1 commit into from
Apr 14, 2023
Merged

fix(L10n): translate powers (JPN) #183

merged 1 commit into from
Apr 14, 2023

Conversation

IDBT
Copy link
Contributor

@IDBT IDBT commented Apr 14, 2023

fix(L10n): add new translations about "Inferno Claw"

Fix: some little mis-translations

Add new translations about "Inferno Claw"
Fix some little mis-translations
@github-actions github-actions bot added the localization Bugs and enhancements related to translation label Apr 14, 2023
@IDBT IDBT closed this Apr 14, 2023
@IDBT
Copy link
Contributor Author

IDBT commented Apr 14, 2023

I submitted the request again because I thought I had accidentally deleted it myself,
However, I am withdrawing this request because I thought I had deleted it by mistake and it had been Merge without any problem.

@scarf005 scarf005 reopened this Apr 14, 2023
@scarf005
Copy link
Owner

scarf005 commented Apr 14, 2023

image

了解しました。ご協力いただきありがとうございます!Pull Request #179#180 の場合は、リポジトリが削除されており、復旧できないようです。そのため、#181#182#183 をマージすることにします。

また、現在「Semantic PR」アプリの動作に失敗した警告が表示されると思います。これは、私たちのプロジェクトがConventional commitルールに従っているためです。このルールによれば、Pull RequestとCommitメッセージは特定のメッセージ形式に従わなければなりません。例えば、このPR(#183)のコミット名とPull Request名がこのルールに従っている場合、以下のような形式のタイトルになります:

fix(L10n): translate powers (JPN)

メッセージ内容は私が修正できるので、既存のPRについては気にしなくても大丈夫です。ただし、今後新しいPRを作成する際には上記のルールに従っていただけるとありがたいです。詳細については、https://conventionalcommits.org/ja/v1.0.0/https://github.com/scarf005/Marisa/blob/fefc4bc643b81d917e53600de8dfc6bee558ce28/docs/semver.mdを参照してください。

再度、ご協力いただきありがとうございます!


Understood. Thank you for your contribution! In the case of Pull Request #179 and #180, the repository has been deleted and it seems to be irrecoverable. Therefore, I will merge #181, #182, and #183.

Also, you might see a warning that the Semantic PR app has failed. This is because our project follows the Conventional commit rules. According to these rules, Pull Request and Commit messages must follow a specific message format. For example, if the commit name and Pull Request name of this PR (#183) follow these rules, the title would look like this:

fix(L10n): translate powers (JPN)

I can modify the message content, so you don't need to worry about the existing PRs. However, I would appreciate it if you follow the above rules when creating new PRs in the future. For more details, please refer to https://conventionalcommits.org/en/v1.0.0/ and https://github.com/scarf005/Marisa/blob/fefc4bc643b81d917e53600de8dfc6bee558ce28/docs/semver.md.

Once again, thank you for your contribution!

@IDBT
Copy link
Contributor Author

IDBT commented Apr 14, 2023

Thank you for your instruction.
I'm going to try to be careful in describing PR next time.

@IDBT IDBT changed the title Translations Powers (JPN) fix(L10n): translate powers (JPN) Apr 14, 2023
@IDBT IDBT changed the title fix(L10n): translate powers (JPN) fix: translate powers (JPN) Apr 14, 2023
@scarf005 scarf005 changed the title fix: translate powers (JPN) fix(L10n): translate powers (JPN) Apr 14, 2023
@scarf005 scarf005 merged commit 470cefd into scarf005:main Apr 14, 2023
3 checks passed
@IDBT IDBT deleted the patch-3 branch April 14, 2023 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
localization Bugs and enhancements related to translation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants