Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(L10n): add events.json (JPN) #187

Merged
merged 2 commits into from
Apr 14, 2023
Merged

feat(L10n): add events.json (JPN) #187

merged 2 commits into from
Apr 14, 2023

Conversation

IDBT
Copy link
Contributor

@IDBT IDBT commented Apr 14, 2023

Summary

  1. create events.json file into JPN folder
  2. translate it to Japanese with reference to English one

add events.json file and translate it to Japanese with reference to English file.
@github-actions github-actions bot added the localization Bugs and enhancements related to translation label Apr 14, 2023
@scarf005 scarf005 changed the title add(L10n): add events.json and translate it feat(L10n): add events.json and translate it Apr 14, 2023
@scarf005 scarf005 changed the title feat(L10n): add events.json and translate it feat(L10n): add events.json (JPN) Apr 14, 2023
@scarf005 scarf005 merged commit 912d62a into scarf005:main Apr 14, 2023
2 checks passed
"OrinTheCat": {
"NAME": "黒い猫",
"DESCRIPTIONS": [
"突然現れた #y黒い #b猫 があなたの目の前で立ち止まり、こちらの行く手を阻んだ。 NL #r~死と災禍の香り~ をまとったその猫に見据えられると、背筋が凍るようだ。 NL 注意を向けてほしそうに、「ニャァ」と鳴いている。"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs missing comma here.

scarf005 added a commit that referenced this pull request Apr 14, 2023
scarf005 added a commit that referenced this pull request Apr 14, 2023
* chore: remove deprecated `pr.py`

* chore: run deno task from project root

* chore: use deno as default formatter

* chore: catch invalid JSON

* fix(L10n): missing comma in events.json (JPN)

regression in #187

* ci(github): check JSON

* style: deno fmt

* build: insert final newline on generated JSON

* ci(github): enforce semantic pr for title and commits

* ci: lint ts, md, json, schema files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
localization Bugs and enhancements related to translation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants