Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CatsCradle: testing language prototype using Fibers to avoid raw promises #259

Merged
merged 2 commits into from Jul 4, 2023

Conversation

noahgibbs
Copy link
Collaborator

@noahgibbs noahgibbs commented Jun 27, 2023

Description

This is a prototype of the CatsCradle testing language, which grew out of brainstorming here: #246

This isn't a full replacement for the promises-based testing language yet, but it's made some good progress in that direction. I'm putting it up as a draft PR to get comments and to let the CI system start chewing on it.

Fixes #246.

Wiki explanation of what the Fibers are basically doing here: https://github.com/scarpe-team/scarpe/wiki/CatsCradleFiberBased.md

Checklist

  • Run tests locally
  • Run linter(check for linter errors)

@noahgibbs noahgibbs changed the title Unit testflow prototype CatsCradle: testing language prototype using Fibers to avoid raw promises Jun 27, 2023
@noahgibbs noahgibbs force-pushed the unit_testflow_prototype branch 7 times, most recently from 4033cfa to a050374 Compare June 27, 2023 14:48
@noahgibbs noahgibbs marked this pull request as ready for review June 27, 2023 14:53
Copy link
Collaborator

@Schwad Schwad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We didn't get to pair on this before the conference! But I'd love to get some time to chat through this this week.

I'm approving for now- if it's cool can we merge after this imminent release? Would be nice to have this in the batch of new features that would accompany a changelog entry

@noahgibbs
Copy link
Collaborator Author

Definitely fine with waiting to merge. Let me know when's good for a call, happy to talk about it.

@noahgibbs noahgibbs merged commit 28f4735 into main Jul 4, 2023
2 checks passed
@noahgibbs noahgibbs deleted the unit_testflow_prototype branch July 4, 2023 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Testing Brainstorming
2 participants