Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct way of passing dynamic service id #3

Closed
wants to merge 4 commits into from

Conversation

4ernovm
Copy link
Contributor

@4ernovm 4ernovm commented Sep 5, 2015

It shows "You cannot dump a container with parameters that contain references to other services" error otherwise

It shows "You cannot dump a container with parameters that contain references to other services" error otherwise
@scaytrase
Copy link
Owner

@4ernovm could you please also check DI instantiations? Tests failed

@4ernovm
Copy link
Contributor Author

4ernovm commented Sep 5, 2015

Damn it! This expression syntax stuff was added starting from 2.4...

@scaytrase
Copy link
Owner

@4ernovm actually we can just require symfony/expression-language ~2.4 as an mandatory requirement, as it does not requires any dependencies by itself.

Are you sure this way of referencing services via parameters is correct? Could you provide some docs on it?

@scaytrase
Copy link
Owner

I'm thinking of implementing compiler pass for configuring service instead of direct yaml configuration, like here

@4ernovm
Copy link
Contributor Author

4ernovm commented Sep 5, 2015

I'm not 100% sure it's correct. I found it in symfony cookbook. But I'm sure, that the way it was before is not good either, because Symfony 2.7 throws error on it. So maybe using compiler pass will be better solution in this case. P.S. Don't forget to switch params in here 4ernovm@5b6e64f

@scaytrase
Copy link
Owner

I've already cherry-picked your commit to another branch, thanks. Experimenting with DI too.

@4ernovm
Copy link
Contributor Author

4ernovm commented Sep 6, 2015

I guess this can be closed

@scaytrase
Copy link
Owner

Ok, thanks for other fixes. I'll think on correct DI

@scaytrase scaytrase closed this Sep 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants