-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct way of passing dynamic service id #3
Conversation
It shows "You cannot dump a container with parameters that contain references to other services" error otherwise
@4ernovm could you please also check DI instantiations? Tests failed |
Damn it! This expression syntax stuff was added starting from 2.4... |
@4ernovm actually we can just require Are you sure this way of referencing services via parameters is correct? Could you provide some docs on it? |
I'm thinking of implementing compiler pass for configuring service instead of direct yaml configuration, like here |
I'm not 100% sure it's correct. I found it in symfony cookbook. But I'm sure, that the way it was before is not good either, because Symfony 2.7 throws error on it. So maybe using compiler pass will be better solution in this case. P.S. Don't forget to switch params in here 4ernovm@5b6e64f |
I've already cherry-picked your commit to another branch, thanks. Experimenting with DI too. |
I guess this can be closed |
Ok, thanks for other fixes. I'll think on correct DI |
It shows "You cannot dump a container with parameters that contain references to other services" error otherwise