Fixed bug where zoo would check nonexistant uid values.

scc · Jul 15, 2003 · 32e7196 · 32e7196
1 parent d5c9f96
commit 32e7196
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/plugins/Zoo/templates/data;zoo;default b/plugins/Zoo/templates/data;zoo;default
@@ -114,7 +114,7 @@ __template__
 	Sorry, this is not an option.
 
 [% CASE 'no_uid' %]
-	Sorry, you did not specify a user.
+	Sorry, you did not specify a valid user.
 
 [% CASE 'over_socialized' %]
 	You are over the limit for the number of friends and foes you can have.

diff --git a/plugins/Zoo/zoo.pl b/plugins/Zoo/zoo.pl
@@ -653,7 +653,9 @@ sub check {
 	my($zoo, $constants, $user, $form, $slashdb) = @_;
 
 	my $uid = $form->{uid} || "";
-	if (!$uid) {
+	my $nickname = $slashdb->getUser($uid, 'nickname');
+
+	if (!$uid || $nickname eq '') {
         	# See comment in plugins/Journal/journal.pl for its call of
         	# getSectionColors() as well.
                 Slash::Utility::Anchor::getSectionColors();
@@ -664,7 +666,6 @@ sub check {
 		return;
 	}
 
-	my $nickname = $slashdb->getUser($uid, 'nickname');
 	my $user_change = { };
 	if ($uid != $user->{uid} && !isAnon($uid) && !$user->{is_anon}) {
 		# Store the fact that this user last looked at that user.