New updates for busy handling by class rather than id, Updates to Sla…

…sh.pm to prevent multiple Todays in firehose footer
scc · Apr 16, 2008 · f37d8d6 · f37d8d6
1 parent 7ab617d
commit f37d8d6
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 3 deletions.
diff --git a/Slash/Slash.pm b/Slash/Slash.pm
@@ -458,6 +458,8 @@ sub getOlderDaysFromDay {
 
 	for ($start..$end) {
 		my $the_day = $slashdb->getDayFromDay($day, $_, $options);
+		next if $the_day == $today && $options->{skip_add_today};
+
 		if (($the_day < $today) || $options->{show_future_days}) {
 			push @$days, $the_day; 
 		}

diff --git a/plugins/Ajax/htdocs/images/common.js b/plugins/Ajax/htdocs/images/common.js
@@ -881,7 +881,7 @@ function firehose_get_next_updates() {
 
 
 function firehose_get_updates_handler(transport) {
-	$('#busy').setClass('hide');
+	$('.busy').hide();
 	var response = eval_response(transport);
 	var processed = 0;
 	firehose_removals = response.update_data.removals;
@@ -942,7 +942,7 @@ function firehose_get_updates(options) {
 		params[i] = firehose_settings[i];
 	}
 
-	$('#busy').removeClass();
+	$('.busy').show();
 	ajax_update(params, '', { onComplete: firehose_get_updates_handler });
 }
 

diff --git a/plugins/FireHose/firehose.css b/plugins/FireHose/firehose.css
@@ -470,3 +470,5 @@ li .tag-actions .not-tag:hover, li .tag-actions .del-tag:hover {color: red;}
 .briefarticle .storylinks .comments.nocomment, .briefarticle .storylinks .comments span  {display: none}
 
 .embed .paginate, .embed .firemenu, .embed a.skin, .copyright.embed { display: none; }
+#fhtablist li:before { content: "";}
+#fhtablist li { padding-left: 0.5em }
diff --git a/plugins/FireHose/templates/list;firehose;default b/plugins/FireHose/templates/list;firehose;default
@@ -83,7 +83,7 @@ YAHOO.util.Event.addListener(window, "load", YAHOO.slashdot.SlashBoxApp.init);
 [% theupdatetime = Slash.timeCalc(Slash.db.getTime(), "%H:%M"); %]
 [% refresh_text = "";
    IF !user.is_anon;
-   	refresh_text = '<span style="font-size:60%">(<span id="pauseorplay">Paused</span> <span id="local_last_update_time">' _ theupdatetime _ '</span><span id="gmt_update_time"></span>)</span><span id="busy" class="hide"><img src="' _ constants.imagedir _ '/spinner.gif" alt="*"></span>';
+	refresh_text = '<span style="font-size:60%">(<span id="pauseorplay">Paused</span> <span id="local_last_update_time">' _ theupdatetime _ '</span><span id="gmt_update_time"></span>)</span><span class="busy" style="display:none"><img src="' _ constants.imagedir _ '/spinner.gif" alt="*"></span>';
    END;
 %]
 [% PROCESS titlebar title="$constants.sitename Firehose $refresh_text" %]