MINOR: add rcond parameter to use future precise numpy default #17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
np.linalg.lstsq
currently elicits a Future Warning:In this PR, I set the rcond parameter to
rcond=None
... to adopt the future Numpy default for this line:xdf/Python/xdf.py
Line 540 in 4e02de7
If we want to keep the old behavior, we should set
rcond=-1
. However, using the future default is probably better. See also here.