[Release v1.5.0] Support both of Swift 5 and 4.2 #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scenee
force-pushed
the
support-swift5
branch
3 times, most recently
from
da51054
to
cb892e7
Compare
scenee
changed the title
scenee
force-pushed
the
support-swift5
branch
5 times, most recently
from
9833d81
to
c5af1b2
Compare
scenee
changed the title
scenee
force-pushed
the
support-swift5
branch
2 times, most recently
from
44471e5
to
f3dac46
Compare
|
Resolve #182 |
|
The default Swift version leaves 4.0. Because it avoids build errors with Carthage on each Xcode version from the source compatibility between Swift 4.0, 4.2 and 5.0. With regard to CocoaPods, the pod spec is going to support |
The default Swift version leaves 4.0. Because it avoids build errors with Carthage on each Xcode version from the source compatibility between Swift 4.0, 4.2 and 5.0. With regard to CocoaPods, the pod spec is going to support `swift_versions` introduced in CocoaPods v1.7.0. For now, a user needs to override `SWIFT_VERSION` appropriately in Podfile.
|
Looking forward to this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's time for FloatingPanel to support both of Swift 5 and Swift 4.x.
The default Swift version becomes 5.0, but the library still supports Swift 4.0/4.1.
I'm sorry I could have supported both of 4.2 and 4.0/4.1 earlier according to #117.
But after this PR you won't bother Xcode warnings about migration to Swift 4.2 or 5.0.
This PR is planning to be released in v1.5.0.