Support bottom content inset for container view #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scenee
requested changes
Aug 28, 2019
nderkach
force-pushed
the
nikolay/fix-bottom-contentinsets
branch
from
dcbd7ba
to
76f8c97
Compare
scenee
reviewed
Aug 30, 2019
scenee
approved these changes
Aug 31, 2019
scenee
pushed a commit
that referenced
this pull request
Aug 31, 2019
and also fix height of a content view resized by the inset Fix #256
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #256
I've removed
containerViewTopInsetConstraintandcontainerViewHeightConstraintin favor of using a bottom constraint.It's not quite clear what's the purpose of
topInteractionBufferandbottomInteractionBufferexactly, but I tried to keep the logic intact.