Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't remove panel on view disappearance #367

Merged
merged 1 commit into from
Jul 11, 2020
Merged

Don't remove panel on view disappearance #367

merged 1 commit into from
Jul 11, 2020

Conversation

lekom
Copy link
Contributor

@lekom lekom commented Jun 21, 2020

  • This suggestion causes the panel to be removed if a full-screen modal is presented over the top.

@scenee
Copy link
Owner

scenee commented Jun 24, 2020

Oh, I just wrote this as an example for removePanelFromParent(), but as you pointed out, it's confusing that calling it in viewWillDisappear while adding a panel in viewDidLoad.

@scenee
Copy link
Owner

scenee commented Jun 24, 2020

I would like to merge your PR but the merge button is disabled. The CI job doesn't seem to be working well. Could you try to push the commit again?

@scenee
Copy link
Owner

scenee commented Jul 11, 2020

The travis-ic integration with Github doesn't look working well. I confirmed this PR build was succeeded so I merge this PR. Thanks you so much.

@scenee scenee merged commit 8903e4e into scenee:master Jul 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lekom @scenee