Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VolumeManager/Volume: Fix issue with compute shaders #386

Merged
merged 1 commit into from May 18, 2021

Conversation

skalarproduktraum
Copy link
Member

@aryaman-gupta had reported an issue where compute shaders would not be used if the VolumeManager is recreated. This PR fixes that, and introduces a new customTextures list in VolumeManager, where the developer can specify custom textures that are not under the VolumeManager's responsibility.

…eused on VolumeManager recreation, add customTextures property
@sonarcloud
Copy link

sonarcloud bot commented Mar 24, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Mar 25, 2021

Codecov Report

Merging #386 (33043b4) into master (35e174c) will increase coverage by 0.15%.
The diff coverage is 61.90%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #386      +/-   ##
============================================
+ Coverage     55.61%   55.76%   +0.15%     
- Complexity     1975     1988      +13     
============================================
  Files           169      169              
  Lines         19350    19356       +6     
  Branches       2986     2993       +7     
============================================
+ Hits          10760    10792      +32     
+ Misses         7452     7433      -19     
+ Partials       1138     1131       -7     
Flag Coverage Δ Complexity Δ
integrationtests 55.72% <61.90%> (+0.14%) 0.00 <0.00> (ø)
unittests 22.80% <0.00%> (+<0.01%) 0.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...n/kotlin/graphics/scenery/volumes/VolumeManager.kt 81.07% <53.33%> (+1.68%) 60.00 <0.00> (+6.00)
src/main/kotlin/graphics/scenery/volumes/Volume.kt 56.36% <83.33%> (+0.44%) 15.00 <0.00> (ø)
...graphics/scenery/backends/vulkan/VulkanRenderer.kt 66.74% <0.00%> (+0.31%) 84.00% <0.00%> (ø%)
...phics/scenery/backends/vulkan/VulkanObjectState.kt 89.06% <0.00%> (+0.78%) 28.00% <0.00%> (+1.00%)
.../kotlin/graphics/scenery/volumes/SceneryContext.kt 64.77% <0.00%> (+1.14%) 41.00% <0.00%> (+1.00%)
...in/graphics/scenery/volumes/VolumeShaderFactory.kt 69.85% <0.00%> (+1.47%) 28.00% <0.00%> (+4.00%)
...raphics/scenery/backends/vulkan/VulkanScenePass.kt 80.00% <0.00%> (+2.09%) 21.00% <0.00%> (ø%)
...hics/scenery/utils/TimestampedConcurrentHashMap.kt 35.29% <0.00%> (+17.65%) 5.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35e174c...33043b4. Read the comment docs.

@skalarproduktraum
Copy link
Member Author

How is this looking @aryaman-gupta, can we merge this?

@aryaman-gupta
Copy link
Member

Yes @skalarproduktraum, looks good! It worked well with my insitu code 👍

@skalarproduktraum skalarproduktraum merged commit e7f86cd into master May 18, 2021
@skalarproduktraum skalarproduktraum deleted the volumemanager-computeshader-fix branch May 18, 2021 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants