Fatal Crash on News Fetch

[lauhayden]

Description of the issue

Ran into bug , cleared data and cache to re-login to server. Then, OCReader keeps crashing when attempting to fetch news (aka on every startup). It seems to be related to the exception below. This issue seems to stem from the new update of Nextcloud News, but not sure.

• OCReader version: 0.31
• Nextcloud news version: 10.2.0
• Android version: 7.1.2

FATAL EXCEPTION: main
Process: email.schaal.ocreader, PID: 11803
java.lang.NullPointerException: Attempt to invoke virtual method 'java.lang.String java.lang.String.substring(int, int)' on a null object reference
	at email.schaal.ocreader.util.FaviconLoader.getDrawable(FaviconLoader.java:65)
	at email.schaal.ocreader.util.FaviconLoader.load(FaviconLoader.java:107)
	at email.schaal.ocreader.view.ItemViewHolder.bindItem(ItemViewHolder.java:92)
	at email.schaal.ocreader.view.ItemsAdapter.onBindViewHolder(ItemsAdapter.java:140)
	at email.schaal.ocreader.view.LoadMoreAdapter.onBindViewHolder(LoadMoreAdapter.java:45)
	at email.schaal.ocreader.view.ErrorAdapter.onBindViewHolder(ErrorAdapter.java:38)
	at email.schaal.ocreader.view.SelectableItemsAdapter.onBindViewHolder(SelectableItemsAdapter.java:24)
	at android.support.v7.widget.RecyclerView$Adapter.onBindViewHolder(RecyclerView.java:6067)
	at android.support.v7.widget.RecyclerView$Adapter.bindViewHolder(RecyclerView.java:6100)
	at android.support.v7.widget.RecyclerView$Recycler.getViewForPosition(RecyclerView.java:5282)
	at android.support.v7.widget.RecyclerView$Recycler.getViewForPosition(RecyclerView.java:5158)
	at android.support.v7.widget.LinearLayoutManager$LayoutState.next(LinearLayoutManager.java:2061)
	at android.support.v7.widget.LinearLayoutManager.layoutChunk(LinearLayoutManager.java:1445)
	at android.support.v7.widget.LinearLayoutManager.fill(LinearLayoutManager.java:1408)
	at android.support.v7.widget.LinearLayoutManager.onLayoutChildren(LinearLayoutManager.java:580)
	at android.support.v7.widget.RecyclerView.dispatchLayoutStep2(RecyclerView.java:3379)
	at android.support.v7.widget.RecyclerView.dispatchLayout(RecyclerView.java:3188)
	at android.support.v7.widget.RecyclerView.onLayout(RecyclerView.java:3632)
	at android.view.View.layout(View.java:17637)
	at android.view.ViewGroup.layout(ViewGroup.java:5575)
	at android.support.v4.widget.SwipeRefreshLayout.onLayout(SwipeRefreshLayout.java:630)
	at android.view.View.layout(View.java:17637)
	at android.view.ViewGroup.layout(ViewGroup.java:5575)
	at android.support.design.widget.HeaderScrollingViewBehavior.layoutChild(HeaderScrollingViewBehavior.java:131)
	at android.support.design.widget.ViewOffsetBehavior.onLayoutChild(ViewOffsetBehavior.java:42)
	at android.support.design.widget.AppBarLayout$ScrollingViewBehavior.onLayoutChild(AppBarLayout.java:1367)
	at android.support.design.widget.CoordinatorLayout.onLayout(CoordinatorLayout.java:849)
	at android.view.View.layout(View.java:17637)
	at android.view.ViewGroup.layout(ViewGroup.java:5575)
	at android.support.v4.widget.DrawerLayout.onLayout(DrawerLayout.java:1193)
	at android.view.View.layout(View.java:17637)
	at android.view.ViewGroup.layout(ViewGroup.java:5575)
	at android.widget.FrameLayout.layoutChildren(FrameLayout.java:323)
	at android.widget.FrameLayout.onLayout(FrameLayout.java:261)
	at android.view.View.layout(View.java:17637)
	at android.view.ViewGroup.layout(ViewGroup.java:5575)
	at android.widget.FrameLayout.layoutChildren(FrameLayout.java:323)
	at android.widget.FrameLayout.onLayout(FrameLayout.java:261)
	at android.view.View.layout(View.java:17637)
	at android.view.ViewGroup.layout(ViewGroup.java:5575)
	at android.widget.FrameLayout.layoutChildren(FrameLayout.java:323)
	at android.widget.FrameLayout.onLayout(FrameLayout.java:261)
	at android.view.View.layout(View.java:17637)
	at android.view.ViewGroup.layout(ViewGroup.java:5575)
	at android.widget.LinearLayout.setChildFrame(LinearLayout.java:1741)
	at android.widget.LinearLayout.layoutVertical(LinearLayout.java:1585)
	at android.widget.LinearLayout.onLayout(LinearLayout.java:1494)
	at android.view.View.layout(View.java:17637)
	at android.view.ViewGroup.layout(ViewGroup.java:5575)
	at android.widget.FrameLayout.layoutChildren(FrameLayout.java:323)
	at android.widget.FrameLayout.onLayout(FrameLayout.java:261)
	at com.android.internal.policy.DecorView.onLayout(DecorView.java:727)
	at android.view.View.layout(View.java:17637)

[ 04-18 19:33:24.794 11803:11803 E/AndroidRuntime ]
	at android.view.ViewGroup.layout(ViewGroup.java:5575)
	at android.view.ViewRootImpl.performLayout(ViewRootImpl.java:2346)
	at android.view.ViewRootImpl.performTraversals(ViewRootImpl.java:2068)
	at android.view.ViewRootImpl.doTraversal(ViewRootImpl.java:1254)
	at android.view.ViewRootImpl$TraversalRunnable.run(ViewRootImpl.java:6338)
	at android.view.Choreographer$CallbackRecord.run(Choreographer.java:874)
	at android.view.Choreographer.doCallbacks(Choreographer.java:686)
	at android.view.Choreographer.doFrame(Choreographer.java:621)
	at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:860)
	at android.os.Handler.handleCallback(Handler.java:751)
	at android.os.Handler.dispatchMessage(Handler.java:95)
	at android.os.Looper.loop(Looper.java:154)
	at android.app.ActivityThread.main(ActivityThread.java:6121)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:889)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:779)

Logcat

Full logcat can be downloaded here

[dvinz]

Hello,

Same problem,

• OCReader version: 0.31
• Nextcloud news version: 10.2.0
• Android version: 5.1.1

E/email.schaal.ocreader.api.APIv12(27980): Failed to execute sync callables E/email.schaal.ocreader.api.APIv12(27980): java.util.concurrent.ExecutionException: com.squareup.moshi.JsonDataException: Expected a long but was NULL at path $.items[0].updatedDate E/email.schaal.ocreader.api.APIv12(27980): at java.util.concurrent.FutureTask.report(FutureTask.java:93) E/email.schaal.ocreader.api.APIv12(27980): at java.util.concurrent.FutureTask.get(FutureTask.java:163) E/email.schaal.ocreader.api.APIv12(27980): at email.schaal.ocreader.api.APIv12$3$1.run(APIv12.java:365) E/email.schaal.ocreader.api.APIv12(27980): at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1112) E/email.schaal.ocreader.api.APIv12(27980): at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:587) E/email.schaal.ocreader.api.APIv12(27980): at java.lang.Thread.run(Thread.java:818) E/email.schaal.ocreader.api.APIv12(27980): Caused by: com.squareup.moshi.JsonDataException: Expected a long but was NULL at path $.items[0].updatedDate E/email.schaal.ocreader.api.APIv12(27980): at com.squareup.moshi.JsonUtf8Reader.nextLong(JsonUtf8Reader.java:756) E/email.schaal.ocreader.api.APIv12(27980): at email.schaal.ocreader.api.json.ItemTypeAdapter.fromJson(ItemTypeAdapter.java:150) E/email.schaal.ocreader.api.APIv12(27980): at email.schaal.ocreader.api.json.ItemTypeAdapter.fromJson(ItemTypeAdapter.java:44) E/email.schaal.ocreader.api.APIv12(27980): at com.squareup.moshi.CollectionJsonAdapter.fromJson(CollectionJsonAdapter.java:75) E/email.schaal.ocreader.api.APIv12(27980): at com.squareup.moshi.CollectionJsonAdapter$2.fromJson(CollectionJsonAdapter.java:52) E/email.schaal.ocreader.api.APIv12(27980): at com.squareup.moshi.JsonAdapter$2.fromJson(JsonAdapter.java:127) E/email.schaal.ocreader.api.APIv12(27980): at com.squareup.moshi.ClassJsonAdapter$FieldBinding.read(ClassJsonAdapter.java:204) E/email.schaal.ocreader.api.APIv12(27980): at com.squareup.moshi.ClassJsonAdapter.fromJson(ClassJsonAdapter.java:166) E/email.schaal.ocreader.api.APIv12(27980): at com.squareup.moshi.JsonAdapter$2.fromJson(JsonAdapter.java:127) E/email.schaal.ocreader.api.APIv12(27980): at com.squareup.moshi.JsonAdapter.fromJson(JsonAdapter.java:34) E/email.schaal.ocreader.api.APIv12(27980): at retrofit2.converter.moshi.MoshiResponseBodyConverter.convert(MoshiResponseBodyConverter.java:42) E/email.schaal.ocreader.api.APIv12(27980): at retrofit2.converter.moshi.MoshiResponseBodyConverter.convert(MoshiResponseBodyConverter.java:25) E/email.schaal.ocreader.api.APIv12(27980): at retrofit2.ServiceMethod.toResponse(ServiceMethod.java:118) E/email.schaal.ocreader.api.APIv12(27980): at retrofit2.OkHttpCall.parseResponse(OkHttpCall.java:212) E/email.schaal.ocreader.api.APIv12(27980): at retrofit2.OkHttpCall.execute(OkHttpCall.java:174) E/email.schaal.ocreader.api.APIv12(27980): at retrofit2.ExecutorCallAdapterFactory$ExecutorCallbackCall.execute(ExecutorCallAdapterFactory.java:89) E/email.schaal.ocreader.api.APIv12(27980): at email.schaal.ocreader.api.APIv12$StarredItemsCallable.getResponse(APIv12.java:501) E/email.schaal.ocreader.api.APIv12(27980): at email.schaal.ocreader.api.APIv12$RealmCallable.call(APIv12.java:421) E/email.schaal.ocreader.api.APIv12(27980): at email.schaal.ocreader.api.APIv12$RealmCallable.call(APIv12.java:409) E/email.schaal.ocreader.api.APIv12(27980): at java.util.concurrent.FutureTask.run(FutureTask.java:237) E/email.schaal.ocreader.api.APIv12(27980): at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:422) E/email.schaal.ocreader.api.APIv12(27980): at java.util.concurrent.FutureTask.run(FutureTask.java:237) E/email.schaal.ocreader.api.APIv12(27980): ... 3 more D/email.schaal.ocreader.service.SyncService(27980): email.schaal.ocreader.action.SYNC_FINISHED: FULL_SYNC

[lauhayden]

I am no longer encountering this problem once I upgraded to 0.34.

[schaal]

I am no longer encountering this problem once I upgraded to 0.34.

That's good to hear