Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metric wind speeds in m/s? #106

Closed
davewhipp opened this issue Jan 31, 2017 · 6 comments
Closed

Metric wind speeds in m/s? #106

davewhipp opened this issue Jan 31, 2017 · 6 comments
Milestone

Comments

@davewhipp
Copy link

A number of countries in Europe use meters per second for wind speeds, rather than kilometers per hour. Would it be possible to have another wind speed option that could display wind speeds in m/s? This appears to already be an option available on darksky.net.

@schachmat
Copy link
Owner

You can use -u si to show m/s speeds, but it will also change temperatures to Kelvin.

@davewhipp
Copy link
Author

OK, good to know. I suppose my request is then whether or not we could have wind speeds in m/s with temperatures in degrees Celsius. I understand using Kelvins for the temperature for the SI units option, but for weather I think m/s + °C would be nice. Thanks for the quick response!

@schachmat
Copy link
Owner

Can you tell me which countries do use that? I think I also checked a few back when I was implementing the support for different unit systems and the three available choices seemed to be enough. You could also create a PR to add the new unit system, as I am currently short on time.

@davewhipp
Copy link
Author

It seems to be common in the Nordic countries, but I don't know where else. I'll think about the pull request. Maybe it is a nice little task to learn a bit of Go.

@schachmat
Copy link
Owner

it's not too hard, you just have to add a new possible argument ("metric-ms"?) in main.go and look at the iface/iface.go file where the unit system transformations are defined and create new if conditions to use the metric or SI system depending on if you are computing distance, temperature or speed.

@schachmat schachmat added this to the 3.0 milestone Mar 7, 2017
schachmat pushed a commit that referenced this issue Mar 11, 2017
@schachmat
Copy link
Owner

@davewhipp, thanks to @R11baka this feature is now merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants