Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Differentiate clear weather at night vs day #88

Closed
wants to merge 1 commit into from

Conversation

galvanist
Copy link

I've had a go at fixing #68 (night should be moon instead of a sun).

This includes an ascii moon/stars for the ascii-art-table frontend and an appropriate character in place for the emoji frontend.

Only fixed for the forecast.io as the placeholders were already there, and I don't have access to any API keys for wwo.

Here's how it looks for a suitably sunny/clear location:
screen shot 2016-04-26 at 23 03 37

- Setup a `CodeClearNight` iface
- Wired up `CodeClearNight` iface for forecast.io
- Created a moon ascii art for ascii-art-table frontend
- Selected `Last Quarter Moon With Face` for emoji frontend
- Todo: differentiate night vs day for wwo backend
@schachmat
Copy link
Owner

Heyho @galvanist.

A few points of feedback:

  • The differentiation between day icon and night icon should not be done by the backend, but just from the Time value inside the frontends. It's okay if you only implement it for the ascii-art-table frontend, as it is the default one.
  • The iface condition codes should not be extended, but rather changed from e.g. Sunny to Clear, so they apply to both night and day conditions.
  • There should be alternatives for all other icons in the ascii-art-table frontend which contain at least part of a sun.

If you want to pick up some of the points, you are most welcome to do so. Otherwise I will probably do it when I have some spare time. The PR will not be merged until the first two points mentioned above are done, the third one adding the missing icons can be done later.

Thanks for drawing that nice icon!

@schachmat schachmat added this to the 3.0 milestone May 6, 2016
@schachmat
Copy link
Owner

Work on this feature continues in #115.

@schachmat schachmat closed this Mar 25, 2017
@schachmat schachmat removed this from the 3.0 milestone Mar 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants