Skip to content
This repository has been archived by the owner on Jul 24, 2020. It is now read-only.

Issue 34 rears it's ugly head on Heroku #226

Closed
colinbowern opened this issue Jul 29, 2011 · 4 comments
Closed

Issue 34 rears it's ugly head on Heroku #226

colinbowern opened this issue Jul 29, 2011 · 4 comments

Comments

@colinbowern
Copy link

Just as Issue 34 outlines I'm getting the trailing slash on Heroku pushes:

C:\projects\demo_app [default tip]> hg push git+ssh://git@heroku.com:warm-leaf-289.git
pushing to git+ssh://git@heroku.com:warm-leaf-289.git/
creating and sending data
["git-receive-pack 'warm-leaf-289.git/'"]

 !  Invalid path.
 !  Syntax is: git@heroku.com:<app>.git where <app> is your app's name

abort: git remote error: The remote server unexpectedly closed the connection.

I pulled the latest build (schacon-hg-git-0.2.6-42-g0b7a273) and that's where it's happening.

Here is my patch (hack) to make it work in the mean time:

--- git_handler.py  Thu Jul 28 22:05:45 2011
+++ patched.git_handler.py  Thu Jul 28 22:11:44 2011
@@ -1066,6 +1066,8 @@

                 port = None
                 host, path = hostpath.split(hostpath_seper, 1)
+               if (host.find('heroku') > 0):
+                    path = path.rstrip('/')
                 if hostpath_seper == '/':
                     transportpath = '/' + path
                 else:
@tangzero
Copy link

tangzero commented Oct 3, 2011

Works for me!

@rodcloutier
Copy link

Same problem using Mercurial 2.0

@dwightgunning
Copy link

Me too... fresh virtualenv on Python 2.7.

(revirda2.7)Maxwell:hellodjango dwight$ pip freeze
Django==1.3.1
distribute==0.6.24
dulwich==0.8.2
hg-git==0.3.1
mercurial==2.0.1
wsgiref==0.1.2

@konradhalas
Copy link

Me too... strange.

@durin42 durin42 closed this as completed Dec 14, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants