Skip to content

Commit

Permalink
added templates for issues and pull requests
Browse files Browse the repository at this point in the history
  • Loading branch information
schaechinger committed Mar 24, 2018
1 parent a174d50 commit e1922be
Show file tree
Hide file tree
Showing 3 changed files with 72 additions and 1 deletion.
25 changes: 25 additions & 0 deletions .github/ISSUES_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
### Description

[Description of the issue]

### Steps to Reproduce

1. [First Step]
2. [Second Step]
3. [and so on...]

**Expected behavior:** [What you expect to happen]

**Actual behavior:** [What actually happens]

**Reproduces how often:** [What percentage of the time does it reproduce?]

### Versions

You can get this information from copy and pasting the output of the package.json in the root directory of the internetmarke package or on the command line from your project root with `npm list --pattern internetmarke` or `yarn list --pattern internetmarke`.

Please also add the version of node you are using with `node --version`.

### Additional Information

Any additional information, configuration or data that might be necessary to reproduce the issue.
46 changes: 46 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
### Requirements

* Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
* All new code requires tests to ensure against regressions

### Description of the Change

<!--
We must be able to understand the design of your change from this description. If we can't get a good idea of what the code will be doing from the description here, the pull request may be closed at the maintainers' discretion. Keep in mind that the maintainer reviewing this PR may not be familiar with or have worked with the code here recently, so please walk us through the concepts.
-->

### Alternate Designs

<!-- Explain what other alternates were considered and why the proposed version was selected -->

### Why Should This Be In Core?

<!-- Explain why this functionality should be part of internetmarke -->

### Benefits

<!-- What benefits will be realized by the code change? -->

### Possible Drawbacks

<!-- What are the possible side-effects or negative impacts of the code change? -->

### Verification Process

<!--
What process did you follow to verify that your change has the desired effects?
- How did you verify that all new functionality works as expected?
- How did you verify that all changed functionality works as expected?
- How did you verify that the change has not introduced any regressions?
Describe the actions you performed (e.g., buttons you clicked, text you typed, commands you ran, etc.), and describe the results you observed.
-->

### Applicable Issues

<!-- Enter any applicable Issues here -->
2 changes: 1 addition & 1 deletion lib/Service/Soap/OneClickForApp.js
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ class OneClickForAppService extends SoapService {
});
}

/**
/**
* Performs a checkout and retrieves the ordered vouchers.
*
* @param {Object} data
Expand Down

0 comments on commit e1922be

Please sign in to comment.