Support for Sqlserver2012 #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set up the structure needed to add Sql Server 2012 specfic changes to FluentMigrator. At the moment, functionality is exactly the same as Sql Server 2008.
New test class for SqlServer2012Generator and can generate sql for the CreateSequenceExpression and DeleteSequenceExpression.
These are exactly the same as for Sql Server 2008 and 2005. Might add integration tests for Create Sequence if it doesn't cause problems for other committers.
|
Right, don't seem to be any objections or suggestions. Is it ok to go ahead and merge this in? |
|
It looks clean to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About time we added support for Sql Server 2012 so I have created an SqlServer2012Generator class that inherits from the 2005 class and adds support for creating sequences.
Is there anything else that we should support for Sql Server 2012? The only thing I can find is ColumnStore indexes. #301 which is not merged in yet adds support for clustered and non-clustered indexes so maybe we should support ColumnStore indexes as well.
I tested creating a Nuget package and it doesn't require any changes to the script for this.