Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix insert expression timespan property #540

Merged

Conversation

spaccabit
Copy link
Contributor

if you do a migration like this:

            Create.Table("TimeRanges")
                .InSchema(MigrationVersionMeta.DefaultSchemaName)
                .WithColumn("ID").AsInt32().Identity().PrimaryKey()
                .WithColumn("Description").AsString(50).Nullable()
                .WithColumn("From").AsTime().NotNullable()
                .WithColumn("To").AsTime().NotNullable()
                .WithColumn("Order").AsInt32().NotNullable().WithDefaultValue(0);

            Insert.IntoTable("TimeRanges")
                .InSchema(MigrationVersionMeta.DefaultSchemaName)
                .Row(new { Description = "00-05", From = TimeSpan.Zero, To = new TimeSpan(0, 5, 59, 59, 999), Order = 0 })
                .Row(new { Description = "06-09", From = new TimeSpan(0, 6, 00, 0, 0), To = new TimeSpan(0, 9, 59, 59, 999), Order = 1 })
                ;

The migration fails.

@tommarien tommarien added this to the vNext milestone Nov 18, 2014
@tommarien tommarien added the bug label Nov 18, 2014
@tommarien tommarien modified the milestones: vNext, 1.3.1 Nov 18, 2014
@tommarien tommarien merged commit 8d254ae into fluentmigrator:master Nov 18, 2014
tommarien added a commit that referenced this pull request Nov 18, 2014
…perty

  Fix OracleQuoterTest
  Fix MySqlQuoterTest  quote value char
  Fix MySql do not support Milliseconds
  Fix TimeSpanIsFormattedQuotes in QuoterTest
  Fix access level
  Test OracleQuoter
  Test MySqlQuoter
  Test GenericQuoter
  Added support for TimeSpan to OracleQuoter
  Added support for TimeSpan to MySqlQuoter
  Added support for TimeSpan to GenericQuoter
@spaccabit spaccabit deleted the FixInsertExpressionTimeSpanProperty branch July 9, 2015 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants