-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow lcobucci/clock v3 #171
Conversation
Test failures seem unrelated 🤷🏻♂️ |
I think just add |
a5b29dd
to
d31c466
Compare
d31c466
to
e3eac47
Compare
Thanks @maxhelias - it did the trick! |
11387c2
to
7fd8189
Compare
OK I went a bit further and switched to use |
7fd8189
to
c750ca9
Compare
In this case you can also delete the |
Removing |
Wow, thanks for going through the effort of updating the thing with the annotations as well! 🤩 Discovered that issue with the doctrine bundle 2.8 just a few days earlier in another project, but it took me way longer to figure out what's going on 😆 Will have a look at the PR on the weekend! |
Released as v6.5.0 Thanks for the clean commit history! 🙇 |
Description
Simply allows https://github.com/lcobucci/clock/releases/tag/3.0.0 - which switches from
stella-maris/clock
topsr/clock
.