Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow lcobucci/clock v3 #171

Merged
merged 2 commits into from
Jan 21, 2023
Merged

Allow lcobucci/clock v3 #171

merged 2 commits into from
Jan 21, 2023

Conversation

IonBazan
Copy link
Contributor

@IonBazan IonBazan commented Jan 19, 2023

Description

Simply allows https://github.com/lcobucci/clock/releases/tag/3.0.0 - which switches from stella-maris/clock to psr/clock.

@IonBazan
Copy link
Contributor Author

Test failures seem unrelated 🤷🏻‍♂️

@maxhelias
Copy link
Contributor

I think just add doctrine/annotations in the require-dev section should fix the test

@IonBazan
Copy link
Contributor Author

Thanks @maxhelias - it did the trick!

@IonBazan
Copy link
Contributor Author

OK I went a bit further and switched to use attribute driver for both routes and entity mapping. This way we can get rid of doctrine/annotations completely as we already require PHP 8+ and Symfony 5.4+ 🚀

@maxhelias
Copy link
Contributor

In this case you can also delete the app/config/routes/annotations.yaml file or alternatively a composer recipes:update should tell you what to do.

@IonBazan
Copy link
Contributor Author

Removing app/config/routes/annotations.yaml is only possible on Symfony 6. Since the app allows 5.4, we need to keep it there for BC.

@scheb
Copy link
Owner

scheb commented Jan 20, 2023

Wow, thanks for going through the effort of updating the thing with the annotations as well! 🤩

Discovered that issue with the doctrine bundle 2.8 just a few days earlier in another project, but it took me way longer to figure out what's going on 😆

Will have a look at the PR on the weekend!

@scheb scheb merged commit 129f90a into scheb:6.x Jan 21, 2023
@scheb
Copy link
Owner

scheb commented Jan 21, 2023

Released as v6.5.0

Thanks for the clean commit history! 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants