-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remember-Me Implementation with Authenticators in Symfony 5.3 #61
Conversation
ced702c
to
ecc2716
Compare
The new approach is confirmed to be working. Also, the changes from symfony/symfony#40145 aren't breaking 2fa in any of the other configurations (i.e. old security system). The implementation is way cleaner now. Just needs a bit a cleanup and test coverage for the new code, then it would be ready to be merged and released as soon as Symfony 5.3 is out. |
e5db3e1
to
c760cd3
Compare
7b1b59d
to
9e1995a
Compare
With symfony 5.3-beta1 out, I'd be happy to try out a beta of this feature too to ensure all is well, but the branches here are not available on the 2fa-bundle subtree split which is making things harder :) Just to say, if you find time to release a beta with this PR merged I'll happily give it a shot. Would rather nail down any issue in the new remember me system before Symfony 5.3.0 hits. |
@Seldaek For the purpose of testing you can reference the I've already tested the changes from symfony/symfony#40145 quite extensively while it was still in development and version that got ultimately merged was working fine. The last CI run was already going against Symfony 5.x and integrations tests (which cover the entire 2fa process including remember-me) have been successful. So I'm very sure we're not running into issues with Symfony 5.3. |
Ok just FYI - can confirm our test suite passes with 5.3-dev and this PR 👍🏻 Looking forward to a release! |
3015498
to
eff5b8a
Compare
…nterface since Symfony 5.3
…equested on login
FYI symfony 5.3 is released and it isn't working with 2fabundle
|
That's expected, that's what this PR is for ;) I'm still at work, so please be patient. If you have to upgrade to Symfony 5.3 on day 0, well, then feel free to refer this branch here until a proper version is assembled and released. |
I'm just playing with the new release, and thought leaving a comment. I didn't mean to rush things at all. :) |
Merged (manually) |
symfony/symfony#40145 is refactoring the implementation of the remember-me feature in Symfony security, with the goal to have a cleaner and more extensible implementation for the authenticator-based security system. The changes are targeting the upcoming Symfony 5.3 release. Changes allow to better integrate the bundle with the remember-me feature from Symfony security, effectively removing the weird "DIC hack" that I'm currently doing to manage remember-me during 2fa.