Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more psr/log versions #24

Merged
merged 1 commit into from
Sep 14, 2022
Merged

Add more psr/log versions #24

merged 1 commit into from
Sep 14, 2022

Conversation

jawira
Copy link
Contributor

@jawira jawira commented Sep 11, 2022

Hi, I was trying to install scheb/tombstone in my project but I had some dependency issues:

$ composer require scheb/tombstone-logger -W
Using version ^1.5 for scheb/tombstone-logger
./composer.json has been updated
Running composer update scheb/tombstone-logger --with-all-dependencies
Loading composer repositories with package information
Updating dependencies
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - scheb/tombstone-logger[v1.5.0, ..., v1.5.1] require psr/log ^1.0 -> found psr/log[1.0.0, ..., 1.1.4] but these were not loaded, likely because it conflicts with another require.
    - Root composer.json requires scheb/tombstone-logger ^1.5 -> satisfiable by scheb/tombstone-logger[v1.5.0, v1.5.1].

You can also try re-running composer require with an explicit version constraint, e.g. "composer require scheb/tombstone-logger:*" to figure out if any version is installable, or "composer require scheb/tombstone-logger:^2.1" if you know which you need.

Installation failed, reverting ./composer.json and ./composer.lock to their original content.

After further investigation I found that -in my project- monolog was incompatible with psr/log v1:

$ composer why psr/log
doctrine/migrations   3.4.2  requires psr/log (^1.1.3 || ^2 || ^3) 
monolog/monolog       3.2.0  requires psr/log (^2.0 || ^3.0) ⬅️ HERE!      
symfony/cache         v6.1.3 requires psr/log (^1.1|^2|^3)         
symfony/error-handler v6.1.3 requires psr/log (^1|^2|^3)           
symfony/http-client   v6.1.4 requires psr/log (^1|^2|^3)           
symfony/http-kernel   v6.1.4 requires psr/log (^1|^2|^3)           
symfony/mailer        v6.1.4 requires psr/log (^1|^2|^3)           
symfony/notifier      v5.4.0 requires psr/log (^1|^2|^3)   

So, in order to improve compatibility I modified composer.json to accept psr/log v2 and v3.

@scheb
Copy link
Owner

scheb commented Sep 13, 2022

Tests are failing, because you need to update the composer.json files from the sub-packackes as well.

@jawira
Copy link
Contributor Author

jawira commented Sep 13, 2022

Tests are failing, because you need to update the composer.json files from the sub-packackes as well.

Done!

@scheb scheb merged commit ad8327a into scheb:1.x Sep 14, 2022
@scheb
Copy link
Owner

scheb commented Sep 14, 2022

Thanks for contributing. Merged and released as v1.5.2

@jawira jawira deleted the update-composer branch September 14, 2022 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants