Adding newer packages versions for PHP 8+ #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allowing newer version of dependencies for PHP 8+
reworking the Application class to get around the issue with methods not matching the implementation
Addig correct version to analyzer sub package
JimTools
force-pushed
the
bug/dep-conflict
branch
from
bbeea14
to
05dd35c
Compare
Psalm is being tested with 8.3, but when infers the PHP version from the package.json it uses 7.1 package can user new langauge features but Psalm will throw errors when this happens. Setting the php version resolve the errors from beenig thrown.
|
Quite surprised this went through without an issue. Would you please add Symfony 7 as well? Or did you try and those didn't work? |
|
@scheb it's a little difficult in v7 of symfony/config they have started to use type return on methods which is a PHP 7.4 feature. but testing this branch out on one of my projects seems fine (famous last words). that would then force the question of whether you want to have the minimum PHP version of 7.4 |
|
Okay, I see the issue. Then we'll just keep it to Symfony 6. Not ideal, but better than the current status quo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When adding the package on newer versions of PHP 8+ while PHPUnit is present the user gets an older version, this is because of conflicts with
phpunit/php-text-templateso Composer will serve a version where this conflict doesn't exist.It's not a bug, but it would be nice if users could get the latest version.
Changes in the PR allow for projects with PHPUnit already installed to get the newer versions.
closes #30