Merge pull request #16 from peter279k/test_enhancement

Test enhancement
scheb · Aug 27, 2018 · 80f56ab · 80f56ab
2 parents 75e03f6 + 9d19035
commit 80f56ab
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 3 deletions.
diff --git a/composer.json b/composer.json
@@ -16,7 +16,7 @@
         "guzzlehttp/guzzle": "^6.0"
     },
     "require-dev": {
-        "phpunit/phpunit": "^5.7",
+        "phpunit/phpunit": "^5.7 || ^6.5",
         "satooshi/php-coveralls": "^1.0"
     },
     "autoload": {

diff --git a/tests/ApiClientIntegrationTest.php b/tests/ApiClientIntegrationTest.php
@@ -6,8 +6,9 @@
 use Scheb\YahooFinanceApi\Results\HistoricalData;
 use Scheb\YahooFinanceApi\Results\Quote;
 use Scheb\YahooFinanceApi\Results\SearchResult;
+use PHPUnit\Framework\TestCase;
 
-class ApiClientIntegrationTest extends \PHPUnit_Framework_TestCase
+class ApiClientIntegrationTest extends TestCase
 {
     const APPLE_NAME = 'Apple';
     const APPLE_SYMBOL = 'AAPL';
@@ -92,6 +93,26 @@ public function getHistoricalData_valuesForInterval_returnHistoricalData($interv
         $this->assertInternalType('int', $historicalData->getVolume());
     }
 
+    /**
+     * @test
+     * @expectedException \InvalidArgumentException
+     * @expectedExceptionMessage Interval must be one of: 1d, 1wk, 1mo
+     */
+    public function getHistoricalData_valuesForInvalidInterval_throwInvalidArgumentException()
+    {
+        $this->client->getHistoricalData(self::APPLE_SYMBOL, 'invalid_interval', new \DateTime('-7 days'), new \DateTime('today'));
+    }
+
+    /**
+     * @test
+     * @expectedException \InvalidArgumentException
+     * @expectedExceptionMessage Start date must be before end date
+     */
+    public function getHistoricalData_startDateIsGreaterThanEndDate_throwInvalidArgumentException()
+    {
+        $this->client->getHistoricalData(self::APPLE_SYMBOL, ApiClient::INTERVAL_1_DAY, new \DateTime('7 days'), new \DateTime('today'));
+    }
+
     public function getTestDataForHistoricalData()
     {
         return [

diff --git a/tests/ResultDecoderTest.php b/tests/ResultDecoderTest.php
@@ -5,8 +5,9 @@
 use Scheb\YahooFinanceApi\Results\HistoricalData;
 use Scheb\YahooFinanceApi\Results\Quote;
 use Scheb\YahooFinanceApi\Results\SearchResult;
+use PHPUnit\Framework\TestCase;
 
-class ResultDecoderTest extends \PHPUnit_Framework_TestCase
+class ResultDecoderTest extends TestCase
 {
     /**
      * @var ResultDecoder