This repository has been archived by the owner on Jun 18, 2024. It is now read-only.
scx: Reorg code a bit and add possible/online cpumask helpers #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Byte-Lab
reviewed
Apr 9, 2024
Byte-Lab
approved these changes
Apr 9, 2024
The allocation could be too short if the possible CPU IDs have holes. Use nr_cpu_ids instead of num_possible_cpus().
So that they are in the same order as the definitions in ext.c. No functional changes.
So that the callers don't have to do it explicitly.
There's no reason to keep the defs of sched_ext_ops and friends in include/linux/sched/ext.h. They're exposed only through vmlinux.h which doesn't care where the ops is defined. Let's move all the things which don't need to be shared in the kernel tree into ext.c. No functional change. So that the callers don't have to do it explicitly.
…and scx_put_cpumask() These are useful to have in general. scx_put_cpumask() is a bit sad but hopefully BPF will develop a way to annotate static lifetime at some point and we won't need these.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.