This repository has been archived by the owner on Jun 18, 2024. It is now read-only.
SCX: Synchronize boot CPU's online state with SCX_RQ_ONLINE #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We weren't synchronizing the boot CPU's online state with scx_rq's online state. This however was getting hidden through the RQ_ONOFF_TOPOLOGY update calls. 3a44769 ("scx: Replace scx_cpu_online percpu var with SCX_RQ_ONLINE flag") masked RQ_ONOFF_TOPOLOGY calls leaving the boot CPU marked offline from SCX's POV always forcing the CPU into local bypass mode, likely leading to reported interactivity problems on scx_rusty. Fix it by synchronizing SCX_RQ_ONLINE with CPU's online states in init_sched_ext_class().
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We weren't synchronizing the boot CPU's online state with scx_rq's online state. This however was getting hidden through the RQ_ONOFF_TOPOLOGY update calls. 3a44769 ("scx: Replace scx_cpu_online percpu var with SCX_RQ_ONLINE flag") masked RQ_ONOFF_TOPOLOGY calls leaving the boot CPU marked offline from SCX's POV always forcing the CPU into local bypass mode, likely leading to reported interactivity problems on scx_rusty.
Fix it by synchronizing SCX_RQ_ONLINE with CPU's online states in init_sched_ext_class().