Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add README.md for systemd services #100

Merged
merged 2 commits into from
Jan 24, 2024

Conversation

sirlucjan
Copy link
Collaborator

Brief information on how to use systemd services with a bunch of useful journald commands.

Signed-off-by: Piotr Gorski <lucjan.lucjanov@gmail.com>
Copy link
Contributor

@Byte-Lab Byte-Lab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for writing this up! Looks good, just left a few comments

README.md Outdated
@@ -364,6 +364,9 @@ $ cargo install scx_rusty

and `scx_rusty` will be built and installed as `~/.cargo/bin/scx_rusty`.

## SystemD services
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: It looks a bit odd to me to say "SystemD" -- can we just stick with "systemd"?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed!

@@ -0,0 +1,54 @@
# A Quick Start Guide

This guide provides instructions on how to start the SCX scheduler and check its logs.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should specify that the guide is specifically about how to start the scheduler as a systemd service. What do you think about this?

This guide provides instructions on how to use an SCX scheduler as a systemd service.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed (probably!)


## Checking Journald Logs

The SCX schedulers do not log to the main journald. Instead, they save logs in a dedicated journald namespace.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about:

The SCX schedulers do not log to the default journald namspace. Instead, they save logs in a dedicated sched-ext namespace.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@sirlucjan
Copy link
Collaborator Author

@Decave Could you check now?

Copy link
Contributor

@Byte-Lab Byte-Lab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just one grammar nit

@@ -0,0 +1,54 @@
# A Quick Start Guide

This guide provides instructions for running the SCX schedulers as a systemd services and checking its logs.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/as a systemd services/as a systemd service

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

Signed-off-by: Piotr Gorski <lucjan.lucjanov@gmail.com>
@Byte-Lab Byte-Lab merged commit 911c3c0 into sched-ext:main Jan 24, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants