-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add README.md for systemd services #100
Conversation
Signed-off-by: Piotr Gorski <lucjan.lucjanov@gmail.com>
8b81d25
to
25cc69b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for writing this up! Looks good, just left a few comments
README.md
Outdated
@@ -364,6 +364,9 @@ $ cargo install scx_rusty | |||
|
|||
and `scx_rusty` will be built and installed as `~/.cargo/bin/scx_rusty`. | |||
|
|||
## SystemD services |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: It looks a bit odd to me to say "SystemD" -- can we just stick with "systemd
"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed!
services/README.md
Outdated
@@ -0,0 +1,54 @@ | |||
# A Quick Start Guide | |||
|
|||
This guide provides instructions on how to start the SCX scheduler and check its logs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should specify that the guide is specifically about how to start the scheduler as a systemd service. What do you think about this?
This guide provides instructions on how to use an SCX scheduler as a systemd service.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed (probably!)
services/README.md
Outdated
|
||
## Checking Journald Logs | ||
|
||
The SCX schedulers do not log to the main journald. Instead, they save logs in a dedicated journald namespace. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about:
The SCX schedulers do not log to the default journald namspace. Instead, they save logs in a dedicated sched-ext
namespace.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
@Decave Could you check now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just one grammar nit
services/README.md
Outdated
@@ -0,0 +1,54 @@ | |||
# A Quick Start Guide | |||
|
|||
This guide provides instructions for running the SCX schedulers as a systemd services and checking its logs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/as a systemd services/as a systemd service
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
Signed-off-by: Piotr Gorski <lucjan.lucjanov@gmail.com>
a9a2385
to
db5d7c5
Compare
Brief information on how to use systemd services with a bunch of useful journald commands.