scx_layered: small idle_cpumask cleanups #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idle_cpumask isn't used at all in pick_idle_cpu_from. The only need for these cpumasks is to check if prev_cpu is a wholly idle CPU (and we only do this when smt_enabled). idle_smtmask is sufficient for that check. Signed-off-by: Dan Schatzberg <schatzberg.dan@gmail.com>
This is a really minor optimization, but we don't need idle_smtmask to schedule pinned tasks, so defer it so the nr_cpus_allowed == 1 path is marginally faster. Signed-off-by: Dan Schatzberg <schatzberg.dan@gmail.com>
htejun
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are two mostly unrelated changes that just cleanup some unnecessary idle cpumask logic in scx_layered