Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[scx_layered] downgrade prometheus-client #115

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

jordalgo
Copy link
Contributor

This library at version 22 is not available in fedora: https://src.fedoraproject.org/rpms/rust-prometheus-client

Rather than bothering the maintainer, let's just downgrade here.

I tested locally. The output still looks sane:

[root@fedora debug]# sudo ./scx_layered file:example.json -o
12:33:51 [INFO] CPUs: online/possible=1/1 nr_cores=1
12:33:51 [INFO] Layered Scheduler Attached
# HELP total Total scheduling events in the period.
# TYPE total gauge
total 250
# HELP local % that got scheduled directly into an idle CPU.
# TYPE local gauge
local 0.0
# HELP open_idle % of open layer tasks scheduled into occupied idle CPUs.
# TYPE open_idle gauge
open_idle 0.0
# HELP affn_viol % which violated configured policies due to CPU affinity restrictions.
# TYPE affn_viol gauge
affn_viol 0.0
# HELP tctx_err Failures to free task contexts.
# TYPE tctx_err gauge
tctx_err 0
# HELP proc_ms CPU time this binary has consumed during the period.
# TYPE proc_ms gauge
proc_ms 5
# HELP busy CPU busy % (100% means all CPUs were fully occupied).
# TYPE busy gauge
busy 0.0
# HELP util CPU utilization % (100% means one CPU was fully occupied).
# TYPE util gauge
util 0.5660943994986982
# HELP load Sum of weight * duty_cycle for all tasks.
# TYPE load gauge
load 0.3895238176528804
# HELP l_util CPU utilization of the layer (100% means one CPU was fully occupied).
# TYPE l_util gauge
l_util{layer_name="batch"} 0.187327642437604
l_util{layer_name="immediate"} 0.0
l_util{layer_name="normal"} 0.37876675706109427
# HELP l_util_frac Fraction of total CPU utilization consumed by the layer.
# TYPE l_util_frac gauge
l_util_frac{layer_name="immediate"} 0.0
l_util_frac{layer_name="normal"} 66.90876246020258
l_util_frac{layer_name="batch"} 33.09123753979742
# HELP l_load Sum of weight * duty_cycle for tasks in the layer.
# TYPE l_load gauge
l_load{layer_name="immediate"} 0.0
l_load{layer_name="batch"} 0.00009382883879342116
l_load{layer_name="normal"} 0.38942998881408699
# HELP l_load_frac Fraction of total load consumed by the layer.
# TYPE l_load_frac gauge
l_load_frac{layer_name="immediate"} 0.0
l_load_frac{layer_name="batch"} 0.02408808769609966
l_load_frac{layer_name="normal"} 99.9759119123039
# HELP l_tasks Number of tasks in the layer.
# TYPE l_tasks gauge
l_tasks{layer_name="normal"} 16
l_tasks{layer_name="batch"} 4
l_tasks{layer_name="immediate"} 0
# HELP l_total Number of scheduling events in the layer.
# TYPE l_total gauge
l_total{layer_name="batch"} 95
l_total{layer_name="immediate"} 0
l_total{layer_name="normal"} 155
# HELP l_local % of scheduling events directly into an idle CPU.
# TYPE l_local gauge
l_local{layer_name="normal"} 0.0
l_local{layer_name="batch"} 0.0
l_local{layer_name="immediate"} 0.0

This library at version 22 is not available in fedora:
https://src.fedoraproject.org/rpms/rust-prometheus-client

Rather than bothering the maintainer, let's just downgrade here.
@jordalgo jordalgo requested a review from htejun January 31, 2024 12:39
@jordalgo
Copy link
Contributor Author

cc @dschatzberg

@dschatzberg
Copy link
Contributor

LGTM

@htejun htejun merged commit a6142f6 into sched-ext:main Jan 31, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants