scx_userland: Print warning about poor performance #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let's make it clear that this scheduler isn't expected to perform well, and instead point people to scx_rustland. Signed-off-by: David Vernet <void@manifault.com>
This is meant to be an example scheduler that won't necessarily run well in production. Let's remove the 3 second timeout and use the system default of 30. Signed-off-by: David Vernet <void@manifault.com>
htejun
approved these changes
Feb 4, 2024
|
@Decave it looks like the CI isn't happy with this change, because the new "WARNING" is interpreted as a failure. I'm wondering if we should just skip scx_userland from the CI tests or maybe print the message rephrasing "WARNING" to something else, "NOTICE" maybe? |
|
Ahh, I see. Ok, let's replace WARNING with NOTICE. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's make it clear that this scheduler isn't expected to perform well, and instead point people to scx_rustland.
Should clarify the situation for issues such as #123
Also increases the timeout for
scx_userlandback to the system default.