Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: detect errors only from stderr #128

Merged
merged 1 commit into from
Feb 5, 2024
Merged

ci: detect errors only from stderr #128

merged 1 commit into from
Feb 5, 2024

Conversation

arighi
Copy link
Collaborator

@arighi arighi commented Feb 5, 2024

Search for potential errors only in the kernel logs and the scheduler stderr.

In this way we can use "error keywords" in the scheduler's output without triggering false positives in the CI (see for example #127).

NOTE: this works, because virtme-ng, when executed in verbose mode, sends the kernel messages to stderr (together with the command's stderr) and it channels the command's stdout to the stdout of the host.

Search for potential errors only in the kernel logs and the scheduler
stderr.

In this way we can use "error keywords" in the scheduler's output
without triggering false positives in the CI (see for example #127).

NOTE: this works, because virtme-ng, when executed in verbose mode,
sends the kernel messages to stderr (together with the command's stderr)
and it channels the command's stdout to the stdout of the host.

Signed-off-by: Andrea Righi <andrea.righi@canonical.com>
Copy link
Contributor

@Byte-Lab Byte-Lab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heh, beat me to it! Thanks for the super quick turnaround

@arighi
Copy link
Collaborator Author

arighi commented Feb 5, 2024

Heh, beat me to it! Thanks for the super quick turnaround

lol you guys approved it and I don't even know if it works. Well, in theory it should work... let's wait for the current run to complete, if CI is happy I'll merge this. :)

@arighi arighi merged commit 55c9c92 into main Feb 5, 2024
1 check passed
@Byte-Lab Byte-Lab deleted the ci-stderr branch March 14, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants