Refresh after attach #150
Merged
Refresh after attach #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 56ff343. For some reason we seem to be non-deterministically failing to see the updated layer values in BPF if we initialize before attaching. Let's just undo this specific part so that we can unblock this being broken, and we can figure it out async. Signed-off-by: David Vernet <void@manifault.com>
As mentioned in the previous commit, for some reason we're sometimes (non-deterministically) not seeing the updated cpumask / layer values in BPF if we initialize the cpumasks here before attaching. Let's undo this for now so to avoid observing buggy behavior, until we figure it out. Signed-off-by: David Vernet <void@manifault.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason we're sometimes (non-deterministically) not seeing the
updated cpumask / layer values in BPF if we initialize the cpumasks here
before attaching. Let's undo this for now so to avoid observing buggy
behavior, until we figure it out.