Add cpumask.rs crate #152
Merged
Add cpumask.rs crate #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let's add a Cpumask trait that schedulers can use to avoid all having to deal directly with BitVec and the like. Signed-off-by: David Vernet <void@manifault.com>
Now that we have cpumask.rs, we can remove some logic from topology.rs and have it create and use Cpumasks. Signed-off-by: David Vernet <void@manifault.com>
htejun
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manipulating cpumasks is a very common occurrence in sched_ext schedulers. The Rust
BitVecobject is available, but it's pretty confusing to use, and we also have to deal with sched_ext-specific things like being able to represent the bitmask in a way that can be consumed by BPF programs, etc.Let's pull that logic into a new cpumask.rs crate that wraps
BitVec, and provides a number of quality-of-life improvements. Along the way, we pull some logic out of topology.rs and move it to cpumask.rs. In a future (soon) change, we'll further update topology.rs to be more generic.