build: limit the maximum amount of parallel cargo build #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Each cargo build is already parallelized, spreading multiple rustc across all the available CPUs by default. Allowing to run multiple instances of cargo at the same time doesn't provide any benefit and it can only increase the risk of triggering OOM conditions or overloading the build system. Therefore, limit the amount of parallel cargo build instances to 1. Signed-off-by: Andrea Righi <andrea.righi@canonical.com>
Byte-Lab
approved these changes
Feb 29, 2024
|
Wait, I'm not sure this actually does what you say. This doesn't limit the number of cargo instances from meson side. This limits the number of rustc instances that each cargo instance kicks off, right? This will make cargo builds really slow. |
htejun
added a commit
that referenced
this pull request
Feb 29, 2024
Revert "Merge pull request #165 from sched-ext/reduce-rust-build-load"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each cargo build is already parallelized, spreading multiple rustc across all the available CPUs by default.
Allowing to run multiple instances of cargo at the same time doesn't provide any benefit and it can only increase the risk of triggering OOM conditions or overloading the build system.
Therefore, limit the amount of parallel cargo build instances to 1.