scx_rlfifo: warn user about performance #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Small improvement to make the scheduler a bit more responsive, without introducing too much complexity or too much CPU overhead. This can be achieved by replacing a sleep of 1ms with a sched_yield() every time that the scheduler has finished to dispatch all the queued tasks. This also makes the code a bit smaller and easier to read. Signed-off-by: Andrea Righi <andrea.righi@canonical.com>
scx_rlfifo is provided as a simple example to show how to use scx_rustland_core and it's not supposed to be used in a real production environment. To prevent performance bug reports print an explicit warning when it's started to clarify the goal of this scheduler. Signed-off-by: Andrea Righi <andrea.righi@canonical.com>
htejun
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small improvement to make the scheduler a little more responsive without introducing extra complexity.
Moreover, print a warning banner when the scheduler starts to clarify its role as a basic example.