Better parsing for clang version #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In my dev enviroment, bpf_clang_ver is coming as NULL, since I am using upstream Clang. Fails graceful in this case. # /usr/local/bin/clang --version clang version 18.0.0git (https://github.com/llvm/llvm-project.git c458f928fad7bbcf08ab1da9949eb2969fc9f89c) Target: x86_64-unknown-linux-gnu Thread model: posix InstalledDir: /usr/local/bin But the command below returns nothing /home/leit/Devel/scx/meson-scripts/get_clang_ver /usr/local/bin/clang Signed-off-by: Breno Leitao <leitao@debian.org>
get_clang_ver fails if clang is built from scratch. Teach get_clang_ver to recognize the clang version even for clang built from git. These are the tests I ran: # /usr/local/bin/clang --version clang version 18.0.0git (https://github.com/llvm/llvm-project.git c458f928fad7bbcf08ab1da9949eb2969fc9f89c) # meson-scripts/get_clang_ver /usr/local/bin/clang 18.0.0 # /usr/bin/clang --version clang version 17.0.6 (CentOS 17.0.6-5.el9) # meson-scripts/get_clang_ver /usr/bin/clang 17.0.6 Signed-off-by: Breno Leitao <leitao@debian.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My development environment uses clang from git, and meson fails with the following error:
Fix this problem by expanding how
get_clang_verparses of clang version