topology: Fall back to cache 0 #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As described in #195, apparently some chips don't export information about their cache topology. There's not much we can do if we don't have that information, so let's just assume a unified cache per node if that happens. Andrea suggested this patch -- I'm applying exactly what he proposed, with a slightly modified comment. Suggested-by: Andrea Righi <andrea.righi@canonical.com> Signed-off-by: David Vernet <void@manifault.com>
|
We probably should further investigate why the cache ID is missing. Maybe we can ask for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #195, apparently some chips don't export information about their cache topology. There's not much we can do if we don't have that information, so let's just assume a unified cache per node if that happens.
Andrea suggested this patch -- I'm applying exactly what he proposed, with a slightly modified comment.
Suggested-by: Andrea Righi andrea.righi@canonical.com